Patch waagent.conf to add firewall rules#8335
Merged
christopherco merged 1 commit intomicrosoft:mainfrom Jul 30, 2024
Merged
Conversation
)" (microsoft#8054)" This reverts commit eb62644.
PawelWMS
approved these changes
Jun 7, 2024
eric-desrochers
approved these changes
Jul 30, 2024
Contributor
eric-desrochers
left a comment
There was a problem hiding this comment.
LGTM
We went through several signoff with Firewall teams, validation and discussion with WALinuxAgent upstream which brought confidence in this change.
corvus-callidus
pushed a commit
that referenced
this pull request
Aug 8, 2024
Add EnableFirewall flag to waagent.conf to protect access to Azure host node services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Add EnableFirewall flag to waagent.conf to protect access to Azure host node services.
This reverts commit eb62644.
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology