Fix npm auth environment variables with yarn 4 (v2)#1230
Merged
ecraig12345 merged 2 commits intov2from May 2, 2026
Merged
Conversation
c90eb29 to
305c070
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the previous fix for this issue forgot yarn 4...
When beachball is invoked via yarn, yarn injects a temp directory into
PATHcontaining a shell-script shim fornode. POSIXshdrops env vars with names containing invalid characters (/,:), so the npm auth token env var (e.g.npm_config_//registry.npmjs.org/:_authToken) gets silently discarded before reachingnpm publish.The fix (filtering those temp dirs from
PATHfor npm commands) already existed inpackageManager.tsbut it turns out it only handled yarn v1, not v4/berry. That version uses the prefixxfs-instead ofyarn--.In this PR:
filterPathForNpmto check forxfs-dirs and move it to a separate filecheckNpmAuthEnvPassthroughwhich is called duringbeachball publishto proactively detect new cases: if a token is configured, it verifies the env var name survives the subprocess boundary. On failure it logs a diagnostic including the fullPATHand, when possible, a directnode ./path/to/beachball/bin/beachball.jsinvocation as a fallback.nodeonPATHto reproduce the env-var-dropping behavior