Use shell: true and explicit cwd for all package manager commands#963
Merged
ecraig12345 merged 1 commit intomasterfrom Apr 24, 2024
Merged
Use shell: true and explicit cwd for all package manager commands#963ecraig12345 merged 1 commit intomasterfrom
ecraig12345 merged 1 commit intomasterfrom
Conversation
ecraig12345
force-pushed
the
ecraig/shell-fix-2
branch
from
675ba68 to
1168cbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #962 since I forgot to update yarn and pnpm...
Combine the manager logic into one file (preserve an npm wrapper for convenience) to consistently share the
shell: truesetting and other logic.Require an explicit
cwdwhen running package manager commands. This might be related to #955.