This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Revert "Update OAuthPrompt.cs" - #1887
Closed
mingweiw wants to merge 1 commit into
Closed
Conversation
This reverts commit 7f955d5.
Collaborator
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll |
Contributor
Contributor
|
Also, if we're reverting this here - what about the JS (any Python) codebase? |
Contributor
|
We need to create a new issue to track this change in both languages, etc. |
Contributor
|
In REviewing all of Jeff's recent email w/ teams, the code that's there appears to be correct. I don't think this PR is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1579