This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[Cherry-pick #1409] Fix for TranscriptLoggerMiddleware not checking responses type - #1426
Closed
stevengum wants to merge 2 commits into
Closed
[Cherry-pick #1409] Fix for TranscriptLoggerMiddleware not checking responses type#1426stevengum wants to merge 2 commits into
stevengum wants to merge 2 commits into
Conversation
…ing responses type (#1409) * add test to reproduce issue #1404 * add test or Transcripts where SendActivitiesHandler is not properly implemented * add bug fix for #1404, more tests * apply PR feedback and refactor code
Pull Request Test Coverage Report for Build 90565
💛 - Coveralls |
Member
Author
|
Closing as the current logic in master was not released in 4.6. Specifically the logic to stamp over the activity.id with the actual resourceresponse.id. In master we will pick up theses tests and revisit the logic in the TranscriptLoggerMiddleware for R7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1404
Specific Changes