This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Enhancements to Conversational Core packages#494
Merged
ryanisgrig merged 14 commits intomainfrom Jan 29, 2021
Merged
Conversation
auto-assign
Bot
requested review from
KayMKM,
bobokids,
darrenj,
lauren-mills,
lzc850612,
pavolum,
ssss141414,
xhr0804 and
xieofxie
ryanisgrig
changed the title
ryanisgrig
requested review from
Quirinevwm and
clearab
and removed request for
KayMKM,
bobokids,
darrenj,
lauren-mills,
lzc850612,
peterinnesmsft,
ssss141414,
xhr0804 and
xieofxie
…HelpDialog packages
…alog" appended to them
pavolum
approved these changes
Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
What is the context of this pull request? Why is it being done?
Update packages related to Conversational Core
Close #469
Close #466
Close #465
Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Greeting package renamed to Welcome
General package split to Cancel
General package split to Help
Tests
Is this covered by existing tests or new ones? If no, why not?
n/a
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
Conversational Core template (#496) needs to be updated to reflect the changes in dependent packages and in the root dialog.