Skip to content

Update styling of graph settings textbox and add shadow#1079

Merged
joseartrivera merged 10 commits into
microsoft:masterfrom
joseartrivera:joriv/morebugs
Apr 9, 2020
Merged

Update styling of graph settings textbox and add shadow#1079
joseartrivera merged 10 commits into
microsoft:masterfrom
joseartrivera:joriv/morebugs

Conversation

@joseartrivera
Copy link
Copy Markdown
Contributor

Fixes #1018, Fixes #986

Description of the changes:

  • Updates text boxes in settings flyout to be consistent with variable text boxes
  • Adds shadow to trace value pop up

How changes were validated:

  • Manual tests

@joseartrivera joseartrivera added the graphing calculator Work items related to the graphing calculator feature. label Mar 9, 2020
@joseartrivera joseartrivera requested a review from sanderl March 9, 2020 22:36
Copy link
Copy Markdown
Collaborator

@rudyhuyn rudyhuyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments!

Comment thread src/Calculator/App.xaml
Comment thread src/Calculator/App.xaml Outdated
Comment thread src/Calculator/App.xaml Outdated
Comment thread src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml Outdated
Comment thread src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp Outdated
Comment thread src/Calculator/Views/GraphingCalculator/GraphingSettings.xaml.cpp
@joseartrivera joseartrivera requested a review from rudyhuyn April 3, 2020 19:27
@sanderl sanderl self-assigned this Apr 8, 2020
Comment thread src/Calculator/App.xaml Outdated
Comment thread src/Calculator/Views/GraphingCalculator/GraphingCalculator.xaml.cpp
Comment thread src/Calculator/Views/GraphingCalculator/GraphingSettings.xaml
@joseartrivera joseartrivera merged commit 3a808b5 into microsoft:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graphing calculator Work items related to the graphing calculator feature.

Projects

None yet

3 participants