Skip to content

Fix tabulator invert #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dan Marshall (danmarshall) merged 2 commits into from
Sep 12, 2025
Merged

Fix tabulator invert #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce0099a
Refactor invert selection logic in tabulator plugin
danmarshall Sep 11, 2025
5b84ac2
new build
danmarshall Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 36 additions & 9 deletions docs/dist/v1/chartifact.markdown.umd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2444,15 +2444,6 @@ ${reconstitutedRules.join("\n\n")}
continue;
}
const spec = specReview.approvedSpec;
const buttons = spec.editable ? `<div class="tabulator-buttons">
<button type="button" class="tabulator-add-row">Add Row</button>
<button type="button" class="tabulator-reset">Reset</button>
</div>` : "";
container.innerHTML = `<div class="tabulator-parent">
<div class="tabulator-nested"></div>
${buttons}
</div>`;
const nestedDiv = container.querySelector(".tabulator-nested");
if (!Tabulator && index2 === 0) {
errorHandler(new Error("Tabulator not found"), pluginName$3, index2, "init", container);
continue;
Expand All @@ -2476,6 +2467,23 @@ ${reconstitutedRules.join("\n\n")}
if (spec.editable && selectableRows) {
delete options.selectableRows;
}
let buttonsHtml = "";
if (spec.editable || selectableRows) {
buttonsHtml = '<div class="tabulator-buttons">';
if (spec.editable) {
buttonsHtml += '<button type="button" class="tabulator-add-row">Add Row</button>';
buttonsHtml += '<button type="button" class="tabulator-reset">Reset</button>';
}
if (selectableRows) {
buttonsHtml += '<button type="button" class="tabulator-invert-selection">Invert Selection</button>';
}
buttonsHtml += "</div>";
}
container.innerHTML = `<div class="tabulator-parent">
<div class="tabulator-nested"></div>
${buttonsHtml}
</div>`;
const nestedDiv = container.querySelector(".tabulator-nested");
const table = new Tabulator(nestedDiv, options);
const tabulatorInstance = {
id: `${pluginName$3}-${index2}`,
Expand Down Expand Up @@ -2565,6 +2573,9 @@ ${reconstitutedRules.join("\n\n")}
});
}
table.setColumns(columns);
if (selectableRows && data.length > 0) {
table.selectRow("all");
}
if (tabulatorInstance.listening) {
outputData();
}
Expand All @@ -2591,6 +2602,22 @@ ${reconstitutedRules.join("\n\n")}
};
}
}
if (selectableRows) {
const invertBtn = container.querySelector(".tabulator-invert-selection");
if (invertBtn) {
invertBtn.onclick = () => {
const allRows = table.getRows();
const selectedRows = new Set(table.getSelectedRows());
allRows.forEach((row) => {
if (selectedRows.has(row)) {
row.deselect();
} else {
row.select();
}
});
};
}
}
return {
...tabulatorInstance,
initialSignals,
Expand Down
11 changes: 2 additions & 9 deletions packages/markdown/src/plugins/tabulator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,19 +260,12 @@ export const tabulatorPlugin: Plugin<TabulatorSpec> = {

if (selectableRows) {
const invertBtn = container.querySelector('.tabulator-invert-selection') as HTMLButtonElement;

if (invertBtn) {
invertBtn.onclick = () => {
const allRows = table.getRows();
const selectedRows = table.getSelectedRows();

// Create a set of selected row IDs for quick lookup
const selectedRowIds = new Set(selectedRows.map(row => row.getIndex()));

// Invert selection: select unselected rows, deselect selected rows
const selectedRows = new Set(table.getSelectedRows());
allRows.forEach(row => {
const rowId = row.getIndex();
if (selectedRowIds.has(rowId)) {
if (selectedRows.has(row)) {
row.deselect();
} else {
row.select();
Expand Down