This repository was archived by the owner on May 20, 2025. It is now read-only.
Lowercasing "ios" directory in release-react#222
Merged
lostintangent merged 1 commit intomasterfrom May 5, 2016
Merged
Conversation
| try { | ||
| var infoPlistContainingFolder: string = path.join("iOS", projectName); | ||
| var infoPlistContainingFolder: string = path.join("ios", projectName); | ||
| var infoPlistContents: string = fs.readFileSync(path.join(infoPlistContainingFolder, "Info.plist")).toString(); |
Contributor
There was a problem hiding this comment.
What about making Info.plist case insensitve?
Member
Author
There was a problem hiding this comment.
This casing is always used. If anything, we have a feature request to enable specifying a different name and/or location, but if the app is using Info.plist, it's always cased this way.
Contributor
|
LGTM! PS: I had the fix as well and waiting on Ruben to verify with travis. Since you already sent this one out, @rub8n we can try this fix out instead. |
Member
Author
|
Ah sorry, I thought you were working on the WKWebView issue. I also verified that this works on Travis, which isn't unique, other than using Linux by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes react-native-code-push#329 by simply lowercasing the "ios" directory we use when trying to auto-detect the app's binary version. The React Native templates have always generated a lowercased "ios" directory, and therefore, we should have already been using this. On Windows and most OS X machines, it wouldn't matter either way, but as noted by the bug, on Linux machines, case matters, and therefore, this PR enables us to work across all platforms by default.
If someone were to change the "ios" directory to be named "iOS" or "IoS" (or whatever), and run
release-reacton a machine with a case-sensitive file-system (e.g. Linux), this PR wouldn't address that scenario. However, I don't believe this is a common scenario at all, so I decided not to worry about it prematurely.