Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Lowercasing "ios" directory in release-react #222

Merged
lostintangent merged 1 commit into from
May 5, 2016
Merged

Lowercasing "ios" directory in release-react #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cli/script/command-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,14 +823,14 @@ function getReactNativeProjectAppVersion(platform: string, projectName: string):
var missingPatchVersionRegex: RegExp = /^\d+\.\d+$/;
if (platform === "ios") {
try {
var infoPlistContainingFolder: string = path.join("iOS", projectName);
var infoPlistContainingFolder: string = path.join("ios", projectName);
var infoPlistContents: string = fs.readFileSync(path.join(infoPlistContainingFolder, "Info.plist")).toString();
Copy link
Copy Markdown
Contributor

@shishirx34 shishirx34 May 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about making Info.plist case insensitve?

Copy link
Copy Markdown
Member Author

@lostintangent lostintangent May 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This casing is always used. If anything, we have a feature request to enable specifying a different name and/or location, but if the app is using Info.plist, it's always cased this way.

} catch (err) {
try {
infoPlistContainingFolder = "iOS";
infoPlistContainingFolder = "ios";
infoPlistContents = fs.readFileSync(path.join(infoPlistContainingFolder, "Info.plist")).toString();
} catch (err) {
throw new Error(`Unable to find or read "Info.plist" in the "iOS/${projectName}" or "iOS" folders.`);
throw new Error(`Unable to find or read "Info.plist" in the "ios/${projectName}" or "ios" folders.`);
}
}

Expand Down