Skip to content

Address more non-ascii characters#329

Merged
MathiasVP merged 1 commit intomicrosoft:UncheckedLeaprYearAfterModification_Refactor_Upstreamfrom
geoffw0:moreascii
Feb 18, 2026
Merged

Address more non-ascii characters#329
MathiasVP merged 1 commit intomicrosoft:UncheckedLeaprYearAfterModification_Refactor_Upstreamfrom
geoffw0:moreascii

Conversation

@geoffw0
Copy link

@geoffw0 geoffw0 commented Feb 18, 2026

Address more non ascii characters in the UncheckedLeapYearAfterModification PR. I ran the check locally this time, since it became apparent the CI check was only reporting the first, not all violations.

It looks like VSCode has removed some unnecessary spacing in the source file alongside the edits.

@bdrodes apologies for this hassle, the check has been quite noisy and isn't flagging anything I'd consider to actually be a problem in 2026. If I had the bandwidth I'd start a discussion about narrowing or disabling the check itself.

@geoffw0
Copy link
Author

geoffw0 commented Feb 18, 2026

I'm, er, not reading the above policy. Accept the PR if you can, otherwise you can implement it by search-and-replace of ± with +- in the test.cpp.

@MathiasVP MathiasVP merged commit a233930 into microsoft:UncheckedLeaprYearAfterModification_Refactor_Upstream Feb 18, 2026
1 of 2 checks passed
@bdrodes
Copy link

bdrodes commented Feb 18, 2026

Sorry @geoffw0 thanks for doing this. This is something you all may want to reconsider given this issue will only become an increasing concern with the fact AI is assisting in writing test code and comments, and that's why these cases are even part of the PR. The AI in vscode makes an inline suggestion that looks right, and adds these characters. It's worse when you fully accept full AI generated test code, or copy any examples from another copilot.

@geoffw0
Copy link
Author

geoffw0 commented Feb 18, 2026

I'll start an internal conversation about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments