Address more non-ascii characters#329
Merged
MathiasVP merged 1 commit intomicrosoft:UncheckedLeaprYearAfterModification_Refactor_Upstreamfrom Feb 18, 2026
Merged
Conversation
Author
|
I'm, er, not reading the above policy. Accept the PR if you can, otherwise you can implement it by search-and-replace of |
a233930
into
microsoft:UncheckedLeaprYearAfterModification_Refactor_Upstream
1 of 2 checks passed
|
Sorry @geoffw0 thanks for doing this. This is something you all may want to reconsider given this issue will only become an increasing concern with the fact AI is assisting in writing test code and comments, and that's why these cases are even part of the PR. The AI in vscode makes an inline suggestion that looks right, and adds these characters. It's worse when you fully accept full AI generated test code, or copy any examples from another copilot. |
Author
|
I'll start an internal conversation about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address more non ascii characters in the UncheckedLeapYearAfterModification PR. I ran the check locally this time, since it became apparent the CI check was only reporting the first, not all violations.
It looks like VSCode has removed some unnecessary spacing in the source file alongside the edits.
@bdrodes apologies for this hassle, the check has been quite noisy and isn't flagging anything I'd consider to actually be a problem in 2026. If I had the bandwidth I'd start a discussion about narrowing or disabling the check itself.