Skip to content

Move null guard statement up in NuGetComponentDetector.IsValidPath to avoid uncessary throw of ArgumentNullException in FileInfo constructor #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

Move null guard statement up in NuGetComponentDetector.IsValidPath to avoid uncessary throw of ArgumentNullException in FileInfo constructor #1371

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e92237c
Move null guard statement up in NuGetComponentDetector.IsValidPath to…
WesHaze Mar 15, 2025
56b27f4
Merge branch 'main' into WesHaze/NugetComponentDetector-IsValidPath-G…
pauld-msft Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Microsoft.ComponentDetection.Detectors/nuget/NuGetComponentDetector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,11 @@
/// <returns>True if path is valid, otherwise it retuns false. </returns>
private bool IsValidPath(string potentialPath)
{
if (potentialPath == null)
{
return false;

Check warning on line 259 in src/Microsoft.ComponentDetection.Detectors/nuget/NuGetComponentDetector.cs

View check run for this annotation

Codecov / codecov/patch

src/Microsoft.ComponentDetection.Detectors/nuget/NuGetComponentDetector.cs#L258-L259 

Added lines #L258 - L259 were not covered by tests
}

FileInfo fileInfo = null;

try
Expand All @@ -265,11 +270,6 @@
return false;
}

if (potentialPath == null)
{
return false;
}

return fileInfo.Exists || fileInfo.Directory.Exists;
}
}
Loading