chore: resolved conflicts#594
Merged
Merged
Conversation
…torage fix: remove enableAnalyticalStorage on Cosmos DB account creation
docs: Updated architecture diagram
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the CosmosDB deployment configuration and regenerated ARM template for the Content Processing Solution Accelerator, including removing Analytical Storage enablement and adjusting resource dependency listing.
Changes:
- Removed
enableAnalyticalStoragefrom the Cosmos DB module configuration and generated template. - Updated generated
templateHashmetadata ininfra/main.json. - Reordered one
dependsOnlist related to private DNS zones.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| infra/main.json | Regenerated template metadata; removed analytical storage parameter; reordered a dependsOn entry for private DNS zones. |
| infra/main.bicep | Removed enableAnalyticalStorage from the Cosmos DB module invocation. |
Comments suppressed due to low confidence (1)
infra/main.json:1
- Reordering entries within a single ARM
dependsOnarray does not enforce provisioning order; ARM treats the list as an unordered set of dependencies. If the intent is to ensure one specific resource is created before another (e.g.,cognitiveServicesaftercontentUnderstanding), model that by adding an explicit dependency edge between the relevant resources (or have the later resource/module explicitlydependsOnthe earlier one), rather than relying on array order.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Vinay-Microsoft
approved these changes
May 19, 2026
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request makes several updates to the CosmosDB configuration and the deployment template for the Content Processing Solution Accelerator. The main changes involve removing the
enableAnalyticalStoragesetting from CosmosDB, updating the template hash, and adjusting the order of dependencies for private DNS zones.CosmosDB Configuration:
enableAnalyticalStorageproperty from the CosmosDB resource configuration in bothinfra/main.bicepand the generatedinfra/main.jsontemplate. This means analytical storage will no longer be enabled by default for the database account. [1] [2]Deployment Template Updates:
templateHashininfra/main.jsonto reflect changes in the Bicep-generated template.Resource Dependency Management:
dependsOnarray for resources to ensure thecontentUnderstandingprivate DNS zone dependency appears beforecognitiveServices, aligning with best practices for resource provisioning order.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information