chore: Make com.microsoft.copilot.eclipse.ui.test a fragment bundle of com.microsoft.copilot.eclipse.ui bundle#361
Open
travkin79 wants to merge 1 commit into
Open
Conversation
This way, tests in com.microsoft.copilot.eclipse.ui.test can access package-private methods and we don't need to make them public. In addition, we no longer need to maintain redundant plug-in dependencies in the test bundle.
travkin79
requested review from
duzitong,
ethanyhou,
jdneo and
xinyi-gong
as code owners
July 20, 2026 11:04
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the com.microsoft.copilot.eclipse.ui.test bundle to be an OSGi fragment of the com.microsoft.copilot.eclipse.ui host bundle, enabling UI tests to access package-private implementation without widening production API visibility and reducing redundant test-bundle dependencies.
Changes:
- Converted
com.microsoft.copilot.eclipse.ui.testinto a fragment bundle viaFragment-Hostand simplified its bundle dependencies. - Introduced
fragment.xmlto contribute test-specific Eclipse extensions (marker + editor registration). - Updated build packaging to include
fragment.xmlinstead ofplugin.xml.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| com.microsoft.copilot.eclipse.ui.test/META-INF/MANIFEST.MF | Declares the test bundle as a fragment of com.microsoft.copilot.eclipse.ui and trims redundant dependencies. |
| com.microsoft.copilot.eclipse.ui.test/fragment.xml | Adds fragment-level extension contributions needed by integration tests (marker + editor). |
| com.microsoft.copilot.eclipse.ui.test/build.properties | Packages fragment.xml in the built test fragment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, tests in
com.microsoft.copilot.eclipse.ui.testcan access package-private methods incom.microsoft.copilot.eclipse.uibundle and we don't need to make them public.In addition, we no longer need to maintain redundant plug-in dependencies in the test bundle.
This is similar to the
com.microsoft.copilot.eclipse.core.testbundle being a fragment bundle withcom.microsoft.copilot.eclipse.coreas the host bundle.