Skip to content

Some uses of co_await were not protected by WINRT_IMPL_COROUTINES #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennykerr merged 3 commits into from
Aug 19, 2021
Merged

Some uses of co_await were not protected by WINRT_IMPL_COROUTINES #1002

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b8a698
Some uses of `co_await` were not protected by `WINRT_IMPL_COROUTINES`
oldnewthing Aug 18, 2021
0a8c40f
Reimplement cancel_asynchronously without coroutines
oldnewthing Aug 18, 2021
e7b2499
Can just remove await_adapter entirely
oldnewthing Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions strings/base_coroutine_foundation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ namespace winrt::impl
}
};

#ifdef WINRT_IMPL_COROUTINES
template <typename Async>
struct await_adapter : enable_await_cancellation
{
Expand Down Expand Up @@ -177,6 +178,7 @@ namespace winrt::impl
}
}
};
#endif

template <typename D>
auto consume_Windows_Foundation_IAsyncAction<D>::get() const
Expand Down Expand Up @@ -793,6 +795,7 @@ namespace std::experimental

WINRT_EXPORT namespace winrt
{
#ifdef WINRT_IMPL_COROUTINES
template <typename... T>
Windows::Foundation::IAsyncAction when_all(T... async)
{
Expand Down Expand Up @@ -838,4 +841,5 @@ WINRT_EXPORT namespace winrt
impl::check_status_canceled(shared->status);
co_return shared->result.GetResults();
}
#endif
}