This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Convert all logging to Serilog - #371
Merged
Merged
Conversation
David Bennett (dkbennett)
marked this pull request as ready for review
March 28, 2024 18:32
| "MicrosoftWindows.Client.WebExperience_cw5n1h2txyewy", | ||
| "Microsoft.Windows.DevHome_8wekyb3d8bbwe", | ||
| "Microsoft.Windows.DevHomeGitHubExtension_8wekyb3d8bbwe", | ||
| "Microsoft.Windows.DevHomeGitHubExtension.Dev_8wekyb3d8bbwe", |
Collaborator
There was a problem hiding this comment.
Should this not be included, or should we include canary as well?
Member
Author
There was a problem hiding this comment.
We should include all of the devhome and extension package name variants so the logging of packages present is complete.
Vineeth Thomas Alex (vineeththomasalex)
approved these changes
Apr 3, 2024
Kristen Schau (krschau)
approved these changes
Apr 3, 2024
Kristen Schau (krschau)
left a comment
Collaborator
There was a problem hiding this comment.
Not sure if you wanted to include the other flavor/extensions from my other comment, but can be done after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Log conversion from serilog, very similar changes as: microsoft/DevHomeAzureExtension#143
References and relevant issues
Detailed description of the pull request / Additional comments
Log formatting changes:
Log has a daily interval where it will be a new file, rolling over 30 days.
Validation steps performed
PR checklist