Skip to content

chore: add missing lodash-es deps - #4298

Merged
chrisdholt merged 2 commits into
microsoft:masterfrom
mattlavio:chore/add-lodash-in-foundation
Feb 2, 2021
Merged

chore: add missing lodash-es deps#4298
chrisdholt merged 2 commits into
microsoft:masterfrom
mattlavio:chore/add-lodash-in-foundation

Conversation

@mattlavio

Copy link
Copy Markdown
Collaborator

Description

Adds the lodash-es dependency as it's been noticed that it was missing in #3825

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@chrisdholt chrisdholt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @m4thieulavoie!

@qlty-cloud-legacy

Copy link
Copy Markdown

Code Climate has analyzed commit 172e3ea and detected 0 issues on this pull request.

View more on Code Climate.

@EisenbergEffect

Copy link
Copy Markdown
Contributor

Any objections here to going ahead with the merge?

@chrisdholt
chrisdholt merged commit 316ba17 into microsoft:master Feb 2, 2021
@mattlavio
mattlavio deleted the chore/add-lodash-in-foundation branch February 2, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants