[Xcode 27] Capture state as weak before any uses#2271
Merged
Conversation
The code was capturing state as weak after already using it, and Xcode 27 now complains of the mixed strong and weak usage. Move the capture up to the HStack itself rather than in the ForEach of the stack's buttons, and use it appropriately inside.
hi-kumar
approved these changes
Jun 9, 2026
nodes11
approved these changes
Jun 9, 2026
mischreiber
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was capturing state as weak after already using it, and Xcode 27 now complains of the mixed strong and weak usage. Move the capture up to the HStack itself rather than in the ForEach of the stack's buttons, and use it appropriately inside.
Platforms Impacted
Description of changes
(a summary of the changes made, often organized by file)
Binary change
(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)
Verification
(how the change was tested, including both manual and automated tests)
Visual Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow