Skip to content

[BottomSheetController] Update collapsedHeightInSafeArea for partial expansion state#2273

Merged
nodes11 merged 2 commits into
microsoft:mainfrom
nodes11:bottomsheet_partial_height
Jun 12, 2026
Merged

[BottomSheetController] Update collapsedHeightInSafeArea for partial expansion state#2273
nodes11 merged 2 commits into
microsoft:mainfrom
nodes11:bottomsheet_partial_height

Conversation

@nodes11

@nodes11 nodes11 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

The collapsedHeightInSafeArea is always set using the sheet’s .collapsed state offset, which doesn't support sheets that open to the .partial state. This can cause UI that should show above the sheet to get hidden behind the sheet because safe area does not get updated correctly.

To fix this, if the targetExpansionState is .partial, calculate the offset using .partial, otherwise use .collapsed.

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

Validated that internal use cases are resolved with this change.

Visual Verification
Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@nodes11 nodes11 requested a review from a team as a code owner June 9, 2026 14:01
@nodes11 nodes11 enabled auto-merge (squash) June 12, 2026 20:01
@nodes11 nodes11 merged commit e08e186 into microsoft:main Jun 12, 2026
7 checks passed
@joannaquu joannaquu mentioned this pull request Jul 9, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants