Skip to content

[iOS][BottomSheetController] Fix issues with corner radius and shadow when glass is enabled - #2278

Merged
nodes11 merged 1 commit into
microsoft:mainfrom
nodes11:bottomsheet_changes_for_glass
Jul 23, 2026
Merged

[iOS][BottomSheetController] Fix issues with corner radius and shadow when glass is enabled#2278
nodes11 merged 1 commit into
microsoft:mainfrom
nodes11:bottomsheet_changes_for_glass

Conversation

@nodes11

@nodes11 nodes11 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

A couple of issues have come up since the previous change which improved iOS 26+ glass support for the BottomSheetController.

  1. The corner radius is not visible - The effectView was a missing a call to set its layer's masksToBounds property to true. Adding this call fixes the issue.
  2. The shadow is missing from the edge of the sheet - Initially it appeared that the shadow applied to the bottom sheet did not work well with glass support. However, after more investigation and an ask to add it back, it was discovered that we were having issues because the shadow was being applied to the wrong layer. To fix the issue, we need to apply the shadow on the bottom sheet's parent view layer.

Binary change

n/a

Verification

  • Validated in demo controllers
  • Validated in internal use cases
Visual Verification Simulator Screenshot - iPhone 17 Pro - 2026-07-23 at 10 21 37

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@nodes11
nodes11 requested a review from a team as a code owner July 23, 2026 17:29
@nodes11
nodes11 enabled auto-merge (squash) July 23, 2026 18:00
@nodes11
nodes11 merged commit 5d881d3 into microsoft:main Jul 23, 2026
7 checks passed
@nodes11 nodes11 mentioned this pull request Aug 3, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants