Skip to content

Rename IndeterminateProgressBar to ProgressBar, add determinite progress mode - #2279

Merged
nodes11 merged 4 commits into
microsoft:mainfrom
nodes11:progress_bar_migration
Jul 30, 2026
Merged

Rename IndeterminateProgressBar to ProgressBar, add determinite progress mode#2279
nodes11 merged 4 commits into
microsoft:mainfrom
nodes11:progress_bar_migration

Conversation

@nodes11

@nodes11 nodes11 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

The exisiting IndeterminateProgressBar only supports showing indeterminate progress and its name reflects that. We need a progress bar that can show both indeterminate and determinate progress.

This change renames to the IndeterminateProgressBar to ProgressBar (MSFProgressBar for Obj-C consumers) and adds a determinate progress mode.

Changes:

  • A bulk rename of IndeterminateProgressBar to ProgressBar. I used Copilot to aid in this process.
  • Added an optional progress property to the MSFProgressBarState (previously MSFIndeterminateProgressBarState), which when non-nil, enables the determinite mode for the progress bar.
  • Added toggle to the demo controller so that both the indeterminate and determinate modes can be tested.

Binary change

(how is our binary size impacted -- see https://github.com/microsoft/fluentui-apple/wiki/Size-Comparison)

Verification

(how the change was tested, including both manual and automated tests)

Visual Verification
Simulator.Screen.Recording.-.iPad.Pro.13-inch.M5.-.2026-07-29.at.08.24.23.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-07-29.at.08.18.57.mov

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@nodes11
nodes11 requested review from a team as code owners July 29, 2026 15:46
Comment thread Demos/FluentUIDemo_iOS/FluentUI.Demo.xcodeproj/project.pbxproj Outdated
Comment thread Sources/FluentUI_iOS/Components/ProgressBar/ProgressBar.swift
Comment thread Sources/FluentUI_iOS/Components/ProgressBar/ProgressBar.swift Outdated
Comment thread Sources/FluentUI_iOS/README.md Outdated
Comment thread MicrosoftFluentUI.podspec Outdated
@joannaquu joannaquu added the API break This PR introduces a breaking API change label Jul 30, 2026
@nodes11
nodes11 merged commit d37085f into microsoft:main Jul 30, 2026
7 checks passed
@nodes11 nodes11 mentioned this pull request Aug 3, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API break This PR introduces a breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants