[dev-v5] AppBar Implement internalized container style for counter badge - #4457
Merged
Conversation
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.8%
|
vnbaaij
enabled auto-merge (squash)
January 9, 2026 15:03
Contributor
There was a problem hiding this comment.
Pull request overview
This PR internalizes the container style for the FluentCounterBadge component, changing it from a public parameter to an internal field that can be set programmatically. This was needed to properly support the FluentAppBarItem component which requires specific container styling.
Key changes:
- Removed public
ContainerStyleparameter from FluentBadge - Added internal
_containerStylefield andSetContainerStyle()method - Updated FluentAppBarItem to set container style programmatically via component reference
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Core/Components/Badge/FluentCounterBadge.razor | Changed from public ContainerStyle parameter to internal _containerStyle field |
| src/Core/Components/Badge/FluentBadge.razor.cs | Removed public ContainerStyle parameter (already has internal field and setter from previous commits) |
| src/Core/Components/AppBar/FluentAppBarItem.razor.cs | Added _counterBadge field and OnAfterRender method to set container style programmatically |
| src/Core/Components/AppBar/FluentAppBarItem.razor | Added component reference and removed declarative ContainerStyle parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dvoituron
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We missed some changes for making the container style on a counter badge internal (needed for the AppBarItem). This PR makes those needed changes