[dev-v5][DataGrid] A11y tweaks - #5029
Merged
Vincent Baaij (vnbaaij) merged 4 commits intoJul 21, 2026
Merged
Conversation
- Render the HeaderTooltip with the DataGrid header button
Vincent Baaij (vnbaaij)
requested a review
from Denis Voituron (dvoituron)
as a code owner
July 20, 2026 19:58
Vincent Baaij (vnbaaij)
changed the title
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the v5 FluentDataGrid column-header “button with menu” rendering to improve accessibility and tooltip behavior, and updates the demo “Typical” DataGrid example to showcase HeaderTooltip.
Changes:
- Add an
aria-labelstrategy for header buttons that anchors the accessible name toTitleand optionally includesHeaderTooltip. - Add menu-related ARIA attributes (
aria-haspopup,aria-controls) on the header button when column actions exist. - Update the “Typical” demo DataGrid columns to provide
HeaderTooltipvalues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Core/Components/DataGrid/Columns/ColumnBase.razor | Adjusts header button accessible name/tooltip wiring and adds ARIA attributes for the header menu trigger. |
| examples/Demo/FluentUI.Demo.Client/Documentation/Components/DataGrid/Examples/DataGridTypical.razor | Adds HeaderTooltip values to demonstrate header-tooltips and menu-trigger labeling. |
Denis Voituron (dvoituron)
approved these changes
Jul 20, 2026
….com/microsoft/fluentui-blazor into users/vnbaaij/dev-v5/fix-issue-#5026
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.8%
Microsoft.FluentUI.AspNetCore.Components.Charts - 100%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings parts of the v4 PR to fix #5026 to v5:
Exposing the expanded state is already done in the web components.
Raised microsoft/fluentui#36414 to get aria-haspopup to render the correct attribute value