[dev-v5] Address RadioGroup issues - #5063
Merged
Vincent Baaij (vnbaaij) merged 6 commits intoAug 1, 2026
Merged
Conversation
- Fix Radio items in a group getting a my-3-o margin - Remove green border from ValidationMessage - Make radioGroup example use an EditContext
Vincent Baaij (vnbaaij)
requested a review
from Denis Voituron (dvoituron)
as a code owner
July 31, 2026 13:37
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.8%
Microsoft.FluentUI.AspNetCore.Components.Charts - 100%
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses several RadioGroup integration and styling issues in the Fluent UI Blazor component library, improving form/validation behavior and aligning demo documentation with proper EditContext-based validation.
Changes:
- Update
FluentRadioGroupto notify the currentEditContextwhen a selection changes. - Adjust RadioGroup CSS isolation to remove unintended margins applied to radio items in a group.
- Remove a debug-looking green dotted border from
FluentValidationMessagestyling. - Update the RadioGroup “Required” demo example to use
EditForm+DataAnnotationsValidatorand bind to a model property.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Core/Components/Radio/FluentRadioGroup.razor.css | Updates isolated CSS selectors to prevent unwanted margins on grouped radio items. |
| src/Core/Components/Radio/FluentRadioGroup.razor.cs | Notifies the Blazor EditContext after radio changes to integrate with form validation/state. |
| src/Core/Components/Forms/FluentValidationMessage.razor.css | Removes the green dotted border from validation message rendering. |
| examples/Demo/FluentUI.Demo.Client/Documentation/Components/Radio/Examples/RadioGroupRequired.razor | Refactors the demo to use an EditForm model and data annotations validation. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…github.com/microsoft/fluentui-blazor into users/vnbaaij.dev-v5/fix-radiogroup-issues
Denis Voituron (dvoituron)
approved these changes
Aug 1, 2026
Vincent Baaij (vnbaaij)
deleted the
users/vnbaaij.dev-v5/fix-radiogroup-issues
branch
August 1, 2026 12:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests still succeed