[dev-v5][AppBar] Fix not showing 'more' item anymore - #5108
Merged
Conversation
Vincent Baaij (vnbaaij)
requested a review
from Denis Voituron (dvoituron)
as a code owner
August 7, 2026 13:50
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 98.7%
Microsoft.FluentUI.AspNetCore.Components.Charts - 100%
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the AppBar “More” overflow trigger being treated as a regular overflow-managed item after the overflow refactor, by giving the trigger a distinct selector/class and updating styling/tests accordingly.
Changes:
- Update the “More” trigger element to use a dedicated class (
fluent-appbar-more-item) so it’s not included in the overflow selector. - Extend AppBar CSS to style the new “More” trigger class similarly to regular items.
- Update the bUnit test selector to find the “More” trigger via the new class.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/Core/Components/AppBar/FluentAppBarTests.razor | Updates the test to locate the “More” trigger using the new .fluent-appbar-more-item selector. |
| src/Core/Components/AppBar/FluentAppBar.razor.css | Adds styling coverage for the new “More” trigger class (with a few selector issues noted in comments). |
| src/Core/Components/AppBar/FluentAppBar.razor | Changes the “More” trigger markup to use the new class; also changes popover offsets (flagged as scope discrepancy). |
Suppressed comments (2)
src/Core/Components/AppBar/FluentAppBar.razor.css:110
- The More button is rendered as a without an child, so the added '.fluent-appbar-more-item[inpopover] ... a.active ...' selector will never match. It should be removed to avoid dead CSS.
.fluent-appbar-item[inpopover]:not(:hover) a.active svg[part="icon-active"],
.fluent-appbar-more-item[inpopover]:not(:hover) a.active svg[part="icon-active"] {
display: none;
}
src/Core/Components/AppBar/FluentAppBar.razor.css:115
- Similarly, the '.fluent-appbar-more-item[inpopover=true] ... a.active ...' selector will never match for the More button. Removing it keeps the CSS aligned with the actual markup.
.fluent-appbar-item[inpopover=true]:not(:hover) a.active svg[part="icon-rest"],
.fluent-appbar-more-item[inpopover=true]:not(:hover) a.active svg[part="icon-rest"] {
display: block;
}
Denis Voituron (dvoituron)
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the earlier Overflow refactor, the 'more' item was now considered to be one of the regular items that could be placed in the overflow popup (because of the selector name being the same). This PR fixes that by supplying a different selector (= class) to this special item