Consolidate theming logic into the new design package#4143
Merged
Conversation
Saadnajmi
approved these changes
Jul 10, 2026
…tive into user/jasonvmo/theme-consolidation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Theme consolidation
This starts to move much of the core theming logic into the @furn/design package. The shifts are:
@furn/theme-types->@furn/design/theming@furn/theme-typesnow is a simple re-export of the values from the design package@furn/theme->@furn/design/theme@furn/themenow is a simple re-export of the values from the design packagePrevious usages within the repository have been rerouted directly to the design package. The old packages become shims and still exist but are effectively deprecated.
The
mockThemefrom tester-core has been moved to the design package as well, to clean up the dependency graph when the default themes eventually move to design.Pinning for default theme values
This also creates per-platform pinning tests to ensure that the values of the default themes remain unchanged through upcoming refactorings.
Verification
Automated tests and pipelines.