Skip to content

docs(rfcs): add convergence devstack rfc#16570

Merged
Hotell merged 2 commits intomicrosoft:masterfrom
Hotell:hotell/rfcs/convergengce-devstack
Feb 11, 2021
Merged

docs(rfcs): add convergence devstack rfc#16570
Hotell merged 2 commits intomicrosoft:masterfrom
Hotell:hotell/rfcs/convergengce-devstack

Conversation

@Hotell
Copy link
Copy Markdown
Contributor

@Hotell Hotell commented Jan 21, 2021 •
edited
Loading

Pull request checklist

- [ ] Addresses an existing issue: Fixes #0000
- [ ] Include a change request file using $ yarn change

Description of changes

  • first RFC for convergence devstack (ported from hackmd)

Focus areas to test

(optional)

Updates:

@Hotell Hotell requested a review from ecraig12345 January 21, 2021 18:20
@ecraig12345 ecraig12345 added the Type: RFC Request for Feedback label Jan 21, 2021
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Jan 21, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bcc3feb:

Sandbox Source
Fluent UI Button Configuration

@fabricteam
Copy link
Copy Markdown
Collaborator

fabricteam commented Jan 21, 2021 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 858 862 5000
BaseButton mount 947 926 5000
Breadcrumb mount 41890 42113 5000
ButtonNext mount 687 712 5000
Checkbox mount 1592 1607 5000
CheckboxBase mount 1335 1348 5000
ChoiceGroup mount 4940 4916 5000
ComboBox mount 998 1034 1000
CommandBar mount 10034 10074 1000
ContextualMenu mount 6157 6062 1000
DefaultButton mount 1195 1165 5000
DetailsRow mount 3698 3767 5000
DetailsRowFast mount 3763 3759 5000
DetailsRowNoStyles mount 3556 3490 5000
Dialog mount 1479 1504 1000
DocumentCardTitle mount 1823 1794 1000
Dropdown mount 3475 3458 5000
FocusTrapZone mount 1807 1820 5000
FocusZone mount 1781 1828 5000
IconButton mount 1814 1880 5000
Label mount 348 324 5000
Layer mount 1836 1789 5000
Link mount 461 478 5000
MakeStyles mount 1944 1945 50000
MenuButton mount 1512 1553 5000
MessageBar mount 2026 1981 5000
Nav mount 3362 3325 1000
OverflowSet mount 1063 1028 5000
Panel mount 1482 1478 1000
Persona mount 918 922 1000
Pivot mount 1426 1449 1000
PrimaryButton mount 1302 1313 5000
Rating mount 7920 7846 5000
SearchBox mount 1373 1384 5000
Shimmer mount 2614 2686 5000
Slider mount 1978 1920 5000
SpinButton mount 5154 5264 5000
Spinner mount 406 414 5000
SplitButton mount 3285 3251 5000
Stack mount 504 525 5000
StackWithIntrinsicChildren mount 1540 1571 5000
StackWithTextChildren mount 4701 4729 5000
SwatchColorPicker mount 10329 10497 5000
Tabs mount 1416 1439 1000
TagPicker mount 2852 2913 5000
TeachingBubble mount 11681 11799 5000
Text mount 428 436 5000
TextField mount 1425 1439 5000
ThemeProvider mount 1382 1425 5000
ThemeProvider virtual-rerender 592 588 5000
ThemeProviderNext mount 2200 2170 5000
Toggle mount 812 824 5000
buttonNative mount 110 113 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.19 0.54 0.35:1 2000 378
🦄 Button.Fluent 0.13 0.21 0.62:1 5000 631
🔧 Checkbox.Fluent 0.66 0.39 1.69:1 1000 660
🎯 Dialog.Fluent 0.17 0.22 0.77:1 5000 825
🔧 Dropdown.Fluent 3.1 0.45 6.89:1 1000 3096
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 764
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 445
🔧 Slider.Fluent 1.57 0.45 3.49:1 1000 1565
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 407
🦄 Tooltip.Fluent 0.12 0.9 0.13:1 5000 584

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
GridMinimalPerf.default 428 393 1.09:1
ButtonMinimalPerf.default 212 196 1.08:1
ChatDuplicateMessagesPerf.default 403 372 1.08:1
FlexMinimalPerf.default 358 330 1.08:1
AvatarMinimalPerf.default 231 216 1.07:1
ListMinimalPerf.default 600 560 1.07:1
RadioGroupMinimalPerf.default 524 499 1.05:1
DividerMinimalPerf.default 439 424 1.04:1
FormMinimalPerf.default 501 480 1.04:1
LayoutMinimalPerf.default 461 445 1.04:1
ListCommonPerf.default 753 724 1.04:1
ReactionMinimalPerf.default 479 462 1.04:1
SegmentMinimalPerf.default 428 410 1.04:1
VideoMinimalPerf.default 720 690 1.04:1
AlertMinimalPerf.default 341 332 1.03:1
AnimationMinimalPerf.default 447 434 1.03:1
HeaderMinimalPerf.default 431 418 1.03:1
HeaderSlotsPerf.default 898 870 1.03:1
ListNestedPerf.default 637 618 1.03:1
ListWith60ListItems.default 707 686 1.03:1
MenuMinimalPerf.default 993 967 1.03:1
TableMinimalPerf.default 485 471 1.03:1
Icon.Fluent 764 739 1.03:1
ButtonUseCssPerf.default 888 868 1.02:1
CardMinimalPerf.default 648 636 1.02:1
CarouselMinimalPerf.default 543 530 1.02:1
CheckboxMinimalPerf.default 2971 2922 1.02:1
ImageMinimalPerf.default 452 443 1.02:1
InputMinimalPerf.default 1334 1311 1.02:1
LabelMinimalPerf.default 478 468 1.02:1
ProviderMinimalPerf.default 982 966 1.02:1
RefMinimalPerf.default 253 249 1.02:1
SkeletonMinimalPerf.default 421 413 1.02:1
SplitButtonMinimalPerf.default 3971 3912 1.02:1
StatusMinimalPerf.default 827 809 1.02:1
TreeMinimalPerf.default 881 861 1.02:1
AccordionMinimalPerf.default 182 181 1.01:1
BoxMinimalPerf.default 411 406 1.01:1
ButtonSlotsPerf.default 639 635 1.01:1
DatepickerMinimalPerf.default 49347 49028 1.01:1
DialogMinimalPerf.default 838 828 1.01:1
DropdownManyItemsPerf.default 794 786 1.01:1
LoaderMinimalPerf.default 768 758 1.01:1
MenuButtonMinimalPerf.default 1728 1707 1.01:1
TableManyItemsPerf.default 2287 2260 1.01:1
Avatar.Fluent 378 374 1.01:1
Image.Fluent 445 441 1.01:1
ButtonOverridesMissPerf.default 1751 1752 1:1
ButtonUseCssNestingPerf.default 1134 1133 1:1
ChatWithPopoverPerf.default 467 468 1:1
DropdownMinimalPerf.default 3100 3100 1:1
EmbedMinimalPerf.default 4365 4372 1:1
ItemLayoutMinimalPerf.default 1354 1358 1:1
TextMinimalPerf.default 414 412 1:1
ToolbarMinimalPerf.default 1055 1053 1:1
TooltipMinimalPerf.default 856 857 1:1
Button.Fluent 631 633 1:1
Checkbox.Fluent 660 662 1:1
Text.Fluent 407 405 1:1
Tooltip.Fluent 584 582 1:1
PopupMinimalPerf.default 746 750 0.99:1
PortalMinimalPerf.default 170 171 0.99:1
IconMinimalPerf.default 752 758 0.99:1
CustomToolbarPrototype.default 3742 3783 0.99:1
Dropdown.Fluent 3096 3122 0.99:1
ChatMinimalPerf.default 669 681 0.98:1
RosterPerf.default 1317 1345 0.98:1
ProviderMergeThemesPerf.default 1582 1613 0.98:1
SliderMinimalPerf.default 1574 1603 0.98:1
TextAreaMinimalPerf.default 568 578 0.98:1
Dialog.Fluent 825 843 0.98:1
AttachmentMinimalPerf.default 172 177 0.97:1
AttachmentSlotsPerf.default 1298 1339 0.97:1
Slider.Fluent 1565 1648 0.95:1
TreeWith60ListItems.default 185 196 0.94:1

@size-auditor
Copy link
Copy Markdown

size-auditor Bot commented Jan 21, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 863cc1a7c4004c36d1b0b7a58d2f382a61563b17 (build)

Hotell
Hotell commented Jan 22, 2021
View reviewed changes
Comment thread rfcs/build-system/01_convergence_devstack.md
Comment thread rfcs/build-system/01_convergence_devstack.md Outdated
Comment thread rfcs/build-system/01_convergence_devstack.md Outdated
Comment thread rfcs/build-system/01_convergence_devstack.md Outdated
Comment thread rfcs/build-system/01_convergence_devstack.md Outdated
Comment thread rfcs/build-system/01_convergence_devstack.md Outdated
Comment thread rfcs/build-system/01_convergence_devstack.md Outdated
Comment thread rfcs/build-system/01_convergence_devstack.md Outdated
Comment thread rfcs/build-system/01_convergence_devstack.md Outdated
Comment thread rfcs/build-system/01_convergence_devstack.md Outdated
@Hotell Hotell mentioned this pull request Jan 29, 2021
Closed
@Hotell Hotell mentioned this pull request Feb 9, 2021
Closed
13 tasks
@Hotell Hotell force-pushed the hotell/rfcs/convergengce-devstack branch from 23c0ef8 to bcc3feb Compare February 11, 2021 15:19
@Hotell
Copy link
Copy Markdown
Contributor Author

Hotell commented Feb 11, 2021 •
edited
Loading

UPDATE:

  • narrowed down the RFC to tackle only 2 issues instead of too many
  • added diagrams

Please approve/comment/reject

  • NOTE: I'll take no activity as approval. thanks for understanding

JustSlone
JustSlone approved these changes Feb 11, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@JustSlone JustSlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for trimming this down. This now covers what we discussed, LGTM

@Hotell Hotell merged commit 6b02081 into microsoft:master Feb 11, 2021
joshualamusga1 pushed a commit to joshualamusga1/fluentui that referenced this pull request Feb 25, 2021
@Hotell @joshualamusga1
docs(rfcs): add convergence devstack rfc (microsoft#16570)
e8e4674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzearing dzearing dzearing left review comments

@JustSlone JustSlone JustSlone approved these changes

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345

@ling1726 ling1726 Awaiting requested review from ling1726

@layershifter layershifter Awaiting requested review from layershifter

+1 more reviewer

@jdhuntington jdhuntington jdhuntington left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@layershifter layershifter

Labels

Type: RFC Request for Feedback

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Hotell @fabricteam @jdhuntington @dzearing @ecraig12345 @layershifter @ling1726 @JustSlone