Skip to content

react-accordion - Adds disabled state#17543

Merged
bsunderhus merged 3 commits intomasterfrom
bsunderhus/accordion-disabled-state
Mar 30, 2021
Merged

react-accordion - Adds disabled state#17543
bsunderhus merged 3 commits intomasterfrom
bsunderhus/accordion-disabled-state

Conversation

@bsunderhus
Copy link
Copy Markdown
Contributor

@bsunderhus bsunderhus commented Mar 24, 2021

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

Adds disabled functionality, which was missing from original implementation. #16926

@bsunderhus bsunderhus assigned bsunderhus and unassigned khmakoto Mar 24, 2021
@bsunderhus bsunderhus enabled auto-merge (squash) March 24, 2021 11:34
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Mar 24, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 947ed00:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam
Copy link
Copy Markdown
Collaborator

fabricteam commented Mar 24, 2021 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1012 1017 5000
BaseButton mount 1009 967 5000
Breadcrumb mount 45090 44459 5000
ButtonNext mount 1432 1417 5000
Checkbox mount 1803 1675 5000
CheckboxBase mount 1434 1431 5000
ChoiceGroup mount 5120 5238 5000
ComboBox mount 1068 1027 1000
CommandBar mount 10519 10531 1000
ContextualMenu mount 6611 6492 1000
DefaultButton mount 1231 1235 5000
DetailsRow mount 3913 3998 5000
DetailsRowFast mount 4060 3950 5000
DetailsRowNoStyles mount 3668 3706 5000
Dialog mount 1614 1591 1000
DocumentCardTitle mount 2004 1907 1000
Dropdown mount 3687 3704 5000
FocusTrapZone mount 1931 1904 5000
FocusZone mount 1939 1925 5000
IconButton mount 2004 1975 5000
Label mount 357 360 5000
Layer mount 2009 1986 5000
Link mount 525 509 5000
MakeStyles mount 1805 1864 50000
MenuButton mount 1671 1713 5000
MessageBar mount 2215 2185 5000
Nav mount 3729 3594 1000
OverflowSet mount 1142 1153 5000
Panel mount 1568 1594 1000
Persona mount 945 906 1000
Pivot mount 1572 1554 1000
PrimaryButton mount 1467 1437 5000
Rating mount 8834 8705 5000
SearchBox mount 1497 1512 5000
Shimmer mount 2932 2885 5000
Slider mount 2201 2244 5000
SpinButton mount 5676 5469 5000
Spinner mount 447 448 5000
SplitButton mount 3564 3527 5000
Stack mount 587 587 5000
StackWithIntrinsicChildren mount 1698 1736 5000
StackWithTextChildren mount 5220 5150 5000
SwatchColorPicker mount 11264 11289 5000
Tabs mount 1565 1539 1000
TagPicker mount 3182 3275 5000
TeachingBubble mount 12507 12722 5000
Text mount 475 486 5000
TextField mount 1547 1584 5000
ThemeProvider mount 1278 1266 5000
ThemeProvider virtual-rerender 644 623 5000
ThemeProviderNext mount 16518 16638 5000
Toggle mount 871 914 5000
buttonNative mount 119 124 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.19 0.51 0.37:1 2000 384
🦄 Button.Fluent 0.13 0.23 0.57:1 5000 674
🔧 Checkbox.Fluent 0.7 0.38 1.84:1 1000 701
🎯 Dialog.Fluent 0.18 0.24 0.75:1 5000 887
🔧 Dropdown.Fluent 3.38 0.44 7.68:1 1000 3382
🔧 Icon.Fluent 0.16 0.07 2.29:1 5000 793
🦄 Image.Fluent 0.09 0.14 0.64:1 5000 466
🔧 Slider.Fluent 1.74 0.49 3.55:1 1000 1736
🔧 Text.Fluent 0.09 0.04 2.25:1 5000 445
🦄 Tooltip.Fluent 0.16 0.94 0.17:1 5000 791

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 258 233 1.11:1
TreeWith60ListItems.default 217 197 1.1:1
ChatWithPopoverPerf.default 452 413 1.09:1
Text.Fluent 445 415 1.07:1
AlertMinimalPerf.default 377 356 1.06:1
SkeletonMinimalPerf.default 449 425 1.06:1
AccordionMinimalPerf.default 188 179 1.05:1
ButtonMinimalPerf.default 218 208 1.05:1
DividerMinimalPerf.default 469 445 1.05:1
LayoutMinimalPerf.default 486 464 1.05:1
TextMinimalPerf.default 435 415 1.05:1
AttachmentSlotsPerf.default 1365 1318 1.04:1
CardMinimalPerf.default 670 643 1.04:1
GridMinimalPerf.default 433 418 1.04:1
ListNestedPerf.default 716 690 1.04:1
IconMinimalPerf.default 786 758 1.04:1
Icon.Fluent 793 764 1.04:1
Tooltip.Fluent 791 762 1.04:1
ButtonSlotsPerf.default 678 659 1.03:1
ButtonUseCssNestingPerf.default 1235 1195 1.03:1
ChatMinimalPerf.default 730 710 1.03:1
ImageMinimalPerf.default 468 453 1.03:1
MenuButtonMinimalPerf.default 1868 1812 1.03:1
RosterPerf.default 1319 1276 1.03:1
Dropdown.Fluent 3382 3298 1.03:1
CheckboxMinimalPerf.default 3101 3050 1.02:1
DropdownMinimalPerf.default 3337 3285 1.02:1
LabelMinimalPerf.default 496 486 1.02:1
ListMinimalPerf.default 606 595 1.02:1
PortalMinimalPerf.default 192 188 1.02:1
ProviderMinimalPerf.default 1079 1059 1.02:1
RadioGroupMinimalPerf.default 543 533 1.02:1
ReactionMinimalPerf.default 484 473 1.02:1
TableManyItemsPerf.default 2401 2356 1.02:1
TextAreaMinimalPerf.default 606 595 1.02:1
CustomToolbarPrototype.default 4074 3975 1.02:1
AnimationMinimalPerf.default 469 465 1.01:1
BoxMinimalPerf.default 429 425 1.01:1
ButtonOverridesMissPerf.default 1848 1836 1.01:1
DialogMinimalPerf.default 907 899 1.01:1
FlexMinimalPerf.default 355 353 1.01:1
FormMinimalPerf.default 533 530 1.01:1
ItemLayoutMinimalPerf.default 1414 1394 1.01:1
ListCommonPerf.default 790 780 1.01:1
LoaderMinimalPerf.default 839 833 1.01:1
PopupMinimalPerf.default 804 795 1.01:1
ProviderMergeThemesPerf.default 1726 1709 1.01:1
SegmentMinimalPerf.default 439 434 1.01:1
ToolbarMinimalPerf.default 1106 1097 1.01:1
TooltipMinimalPerf.default 1075 1066 1.01:1
TreeMinimalPerf.default 918 908 1.01:1
DropdownManyItemsPerf.default 837 838 1:1
EmbedMinimalPerf.default 4705 4693 1:1
HeaderSlotsPerf.default 927 929 1:1
SliderMinimalPerf.default 1685 1688 1:1
TableMinimalPerf.default 490 489 1:1
VideoMinimalPerf.default 747 749 1:1
Slider.Fluent 1736 1735 1:1
CarouselMinimalPerf.default 558 563 0.99:1
InputMinimalPerf.default 1388 1396 0.99:1
RefMinimalPerf.default 269 271 0.99:1
AttachmentMinimalPerf.default 183 187 0.98:1
ChatDuplicateMessagesPerf.default 329 337 0.98:1
DatepickerMinimalPerf.default 51218 52124 0.98:1
HeaderMinimalPerf.default 437 446 0.98:1
SplitButtonMinimalPerf.default 4209 4315 0.98:1
Avatar.Fluent 384 392 0.98:1
Button.Fluent 674 686 0.98:1
Checkbox.Fluent 701 715 0.98:1
Image.Fluent 466 474 0.98:1
ButtonUseCssPerf.default 924 950 0.97:1
MenuMinimalPerf.default 1029 1056 0.97:1
Dialog.Fluent 887 910 0.97:1
ListWith60ListItems.default 733 763 0.96:1
StatusMinimalPerf.default 836 882 0.95:1

@size-auditor
Copy link
Copy Markdown

size-auditor bot commented Mar 24, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: b8e8697d9f3ff285687b7cba27b9ac037a0cb727 (build)

@bsunderhus bsunderhus merged commit 157285a into master Mar 30, 2021
@layershifter layershifter deleted the bsunderhus/accordion-disabled-state branch March 30, 2021 11:33
@msft-fluent-ui-bot
Copy link
Copy Markdown
Collaborator

msft-fluent-ui-bot commented Mar 31, 2021

🎉@fluentui/react-accordion@v9.0.0-alpha.8 has been released which incorporates this pull request.:tada:

Handy links:

miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request May 5, 2021
@bsunderhus @miroslavstastny
react-accordion - Adds disabled state (microsoft#17543)
97a958e 
* Adds disabled state in AccordionItem

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layershifter layershifter layershifter approved these changes

@ling1726 ling1726 Awaiting requested review from ling1726

Assignees

@bsunderhus bsunderhus

Labels

Component: Accordion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bsunderhus @fabricteam @msft-fluent-ui-bot @layershifter @khmakoto