chore: fix cxe-prg org codeowners and add react-text owner#18997
Merged
Hotell merged 1 commit intomicrosoft:masterfrom Jul 19, 2021
Merged
chore: fix cxe-prg org codeowners and add react-text owner#18997Hotell merged 1 commit intomicrosoft:masterfrom
Hotell merged 1 commit intomicrosoft:masterfrom
Conversation
ling1726
approved these changes
Jul 19, 2021
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8b9249f:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 63f7b2dc6293e7ea4e4f5484c6c81af1c01d80ec (build) |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 869 | 818 | 5000 | |
| BaseButton | mount | 943 | 1000 | 5000 | |
| Breadcrumb | mount | 2705 | 2659 | 1000 | |
| ButtonNext | mount | 547 | 542 | 5000 | |
| Checkbox | mount | 1634 | 1627 | 5000 | |
| CheckboxBase | mount | 1366 | 1364 | 5000 | |
| ChoiceGroup | mount | 5036 | 5025 | 5000 | |
| ComboBox | mount | 1023 | 1092 | 1000 | |
| CommandBar | mount | 10367 | 10365 | 1000 | |
| ContextualMenu | mount | 6413 | 6215 | 1000 | |
| DefaultButton | mount | 1182 | 1203 | 5000 | |
| DetailsRow | mount | 3893 | 3916 | 5000 | |
| DetailsRowFast | mount | 3925 | 3931 | 5000 | |
| DetailsRowNoStyles | mount | 3728 | 3691 | 5000 | |
| Dialog | mount | 2237 | 2261 | 1000 | |
| DocumentCardTitle | mount | 147 | 156 | 1000 | |
| Dropdown | mount | 3418 | 3456 | 5000 | |
| FluentProviderNext | mount | 6993 | 6997 | 5000 | |
| FocusTrapZone | mount | 1842 | 1864 | 5000 | |
| FocusZone | mount | 1781 | 1856 | 5000 | |
| IconButton | mount | 1859 | 1820 | 5000 | |
| Label | mount | 348 | 350 | 5000 | |
| Layer | mount | 1876 | 1862 | 5000 | |
| Link | mount | 482 | 494 | 5000 | |
| MakeStyles | mount | 1795 | 1905 | 50000 | |
| MenuButton | mount | 1568 | 1586 | 5000 | |
| MessageBar | mount | 2104 | 2064 | 5000 | |
| Nav | mount | 3535 | 3464 | 1000 | |
| OverflowSet | mount | 1084 | 1056 | 5000 | |
| Panel | mount | 2139 | 2139 | 1000 | |
| Persona | mount | 885 | 884 | 1000 | |
| Pivot | mount | 1506 | 1443 | 1000 | |
| PrimaryButton | mount | 1349 | 1331 | 5000 | |
| Rating | mount | 8227 | 8279 | 5000 | |
| SearchBox | mount | 1423 | 1410 | 5000 | |
| Shimmer | mount | 2771 | 2738 | 5000 | |
| Slider | mount | 2085 | 2057 | 5000 | |
| SpinButton | mount | 5194 | 5218 | 5000 | |
| Spinner | mount | 424 | 416 | 5000 | |
| SplitButton | mount | 3317 | 3298 | 5000 | |
| Stack | mount | 519 | 535 | 5000 | |
| StackWithIntrinsicChildren | mount | 1692 | 1720 | 5000 | |
| StackWithTextChildren | mount | 4967 | 5036 | 5000 | |
| SwatchColorPicker | mount | 10817 | 10792 | 5000 | |
| Tabs | mount | 1511 | 1484 | 1000 | |
| TagPicker | mount | 2624 | 2630 | 5000 | |
| TeachingBubble | mount | 12133 | 12142 | 5000 | |
| Text | mount | 445 | 458 | 5000 | |
| TextField | mount | 1466 | 1461 | 5000 | |
| ThemeProvider | mount | 1201 | 1200 | 5000 | |
| ThemeProvider | virtual-rerender | 622 | 613 | 5000 | |
| Toggle | mount | 853 | 868 | 5000 | |
| buttonNative | mount | 119 | 119 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 212 | 170 | 1.25:1 |
| TreeWith60ListItems.default | 200 | 178 | 1.12:1 |
| LabelMinimalPerf.default | 437 | 397 | 1.1:1 |
| PortalMinimalPerf.default | 187 | 172 | 1.09:1 |
| AlertMinimalPerf.default | 306 | 283 | 1.08:1 |
| AnimationMinimalPerf.default | 449 | 421 | 1.07:1 |
| ChatWithPopoverPerf.default | 398 | 372 | 1.07:1 |
| RefMinimalPerf.default | 250 | 234 | 1.07:1 |
| SkeletonMinimalPerf.default | 386 | 361 | 1.07:1 |
| HeaderMinimalPerf.default | 385 | 364 | 1.06:1 |
| TextMinimalPerf.default | 377 | 355 | 1.06:1 |
| ChatMinimalPerf.default | 709 | 676 | 1.05:1 |
| AttachmentMinimalPerf.default | 173 | 166 | 1.04:1 |
| HeaderSlotsPerf.default | 844 | 812 | 1.04:1 |
| ItemLayoutMinimalPerf.default | 1320 | 1269 | 1.04:1 |
| LoaderMinimalPerf.default | 731 | 703 | 1.04:1 |
| TextAreaMinimalPerf.default | 559 | 535 | 1.04:1 |
| AttachmentSlotsPerf.default | 1131 | 1097 | 1.03:1 |
| ListMinimalPerf.default | 552 | 538 | 1.03:1 |
| ListNestedPerf.default | 608 | 593 | 1.03:1 |
| MenuButtonMinimalPerf.default | 1784 | 1739 | 1.03:1 |
| PopupMinimalPerf.default | 613 | 595 | 1.03:1 |
| ProviderMinimalPerf.default | 1075 | 1041 | 1.03:1 |
| TableManyItemsPerf.default | 2079 | 2012 | 1.03:1 |
| TreeMinimalPerf.default | 863 | 841 | 1.03:1 |
| ProviderMergeThemesPerf.default | 1696 | 1657 | 1.02:1 |
| SegmentMinimalPerf.default | 360 | 354 | 1.02:1 |
| SliderMinimalPerf.default | 1648 | 1618 | 1.02:1 |
| SplitButtonMinimalPerf.default | 4072 | 4007 | 1.02:1 |
| StatusMinimalPerf.default | 730 | 715 | 1.02:1 |
| ToolbarMinimalPerf.default | 1034 | 1017 | 1.02:1 |
| VideoMinimalPerf.default | 675 | 662 | 1.02:1 |
| BoxMinimalPerf.default | 363 | 358 | 1.01:1 |
| CardMinimalPerf.default | 606 | 598 | 1.01:1 |
| DatepickerMinimalPerf.default | 5631 | 5590 | 1.01:1 |
| DialogMinimalPerf.default | 815 | 809 | 1.01:1 |
| DividerMinimalPerf.default | 397 | 392 | 1.01:1 |
| DropdownMinimalPerf.default | 3175 | 3131 | 1.01:1 |
| ListCommonPerf.default | 689 | 683 | 1.01:1 |
| MenuMinimalPerf.default | 873 | 862 | 1.01:1 |
| CheckboxMinimalPerf.default | 2840 | 2845 | 1:1 |
| FormMinimalPerf.default | 440 | 441 | 1:1 |
| GridMinimalPerf.default | 357 | 356 | 1:1 |
| ImageMinimalPerf.default | 410 | 408 | 1:1 |
| CustomToolbarPrototype.default | 3971 | 3988 | 1:1 |
| ButtonOverridesMissPerf.default | 1749 | 1758 | 0.99:1 |
| CarouselMinimalPerf.default | 493 | 499 | 0.99:1 |
| DropdownManyItemsPerf.default | 739 | 747 | 0.99:1 |
| EmbedMinimalPerf.default | 4303 | 4357 | 0.99:1 |
| InputMinimalPerf.default | 1309 | 1316 | 0.99:1 |
| LayoutMinimalPerf.default | 396 | 399 | 0.99:1 |
| TableMinimalPerf.default | 425 | 431 | 0.99:1 |
| TooltipMinimalPerf.default | 1068 | 1081 | 0.99:1 |
| FlexMinimalPerf.default | 292 | 297 | 0.98:1 |
| ListWith60ListItems.default | 682 | 699 | 0.98:1 |
| RadioGroupMinimalPerf.default | 478 | 488 | 0.98:1 |
| ReactionMinimalPerf.default | 402 | 412 | 0.98:1 |
| ChatDuplicateMessagesPerf.default | 307 | 315 | 0.97:1 |
| AccordionMinimalPerf.default | 158 | 164 | 0.96:1 |
| IconMinimalPerf.default | 604 | 629 | 0.96:1 |
| AvatarMinimalPerf.default | 219 | 231 | 0.95:1 |
| RosterPerf.default | 1296 | 1359 | 0.95:1 |
| ButtonSlotsPerf.default | 551 | 605 | 0.91:1 |
theerebuss
approved these changes
Jul 19, 2021
| packages/react-components/ @layershifter @miroslavstastny | ||
| packages/react-focus/ @microsoft/cxe-red @khmakoto | ||
| packages/react-image/ @cxe-prg | ||
| packages/react-image/ @microsoft/@cxe-prg |
Member
There was a problem hiding this comment.
It seems that this PR breaks CODEOWNERS at all... @Hotell Can you please check?

Even Github highlighter considers these entries invalid
There should be a single @:
-packages/react-image/ @microsoft/@cxe-prg
+packages/react-image/ @microsoft/cxe-prg
Contributor
Author
There was a problem hiding this comment.
well, that's why I hate search/replace without proper context awareness :D , thx
PeterDraex
pushed a commit
to PeterDraex/fluentui
that referenced
this pull request
Aug 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
[ ] Addresses an existing issue[ ] Include a change request file using$ yarn changeDescription of changes
@cxe-prgwas not working properly - this adds while team alias including orgFocus areas to test
(optional)