Skip to content

chore: fix cxe-prg org codeowners and add react-text owner #18997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hotell merged 1 commit into from
Jul 19, 2021
+4 −3
Merged

chore: fix cxe-prg org codeowners and add react-text owner #18997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,11 @@ packages/react-card/ @microsoft/cxe-red @khmakoto
packages/react-checkbox/ @microsoft/cxe-red @khmakoto
packages/react-components/ @layershifter @miroslavstastny
packages/react-focus/ @microsoft/cxe-red @khmakoto
packages/react-image/ @cxe-prg
packages/react-image/ @microsoft/@cxe-prg
Copy link
Copy Markdown
Member

@layershifter layershifter Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this PR breaks CODEOWNERS at all... @Hotell Can you please check?

image
Even Github highlighter considers these entries invalid

There should be a single @:

-packages/react-image/ @microsoft/@cxe-prg
+packages/react-image/ @microsoft/cxe-prg

Copy link
Copy Markdown
Contributor Author

@Hotell Hotell Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, that's why I hate search/replace without proper context awareness :D , thx

packages/react-text/ @microsoft/@cxe-prg
packages/react-input/ @microsoft/cxe-red @ecraig12345
packages/react-storybook/ @cxe-prg @ling1726 @layershifter
packages/storybook/ @cxe-prg @ling1726 @layershifter
packages/react-storybook/ @microsoft/@cxe-prg @ling1726 @layershifter
packages/storybook/ @microsoft/@cxe-prg @ling1726 @layershifter
packages/react-link/ @microsoft/cxe-red @khmakoto
packages/react-slider/ @microsoft/cxe-red
packages/react-tabs/ @microsoft/cxe-red @behowell
Expand Down