fix(react-input, react-textarea): Fix Field control size handling#36453
Open
dmytrokirpa wants to merge 1 commit into
Open
fix(react-input, react-textarea): Fix Field control size handling#36453dmytrokirpa wants to merge 1 commit into
dmytrokirpa wants to merge 1 commit into
Conversation
…Input and Textarea
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/CalendarCompat 4 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/CalendarCompat.multiDayView.default.chromium_1.png | 478 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - High Contrast.default.chromium.png | 1202 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - RTL.default.chromium.png | 479 | Changed |
| vr-tests-react-components/CalendarCompat.multiDayView - Dark Mode.default.chromium.png | 1096 | Changed |
vr-tests-react-components/Field 5 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Field.Input+horizontal.default.chromium.png | 5610 | Changed |
| vr-tests-react-components/Field.Textarea+horizontal.default.chromium.png | 2696 | Changed |
| vr-tests-react-components/Field.Textarea.default.chromium.png | 3543 | Changed |
| vr-tests-react-components/Field.size-large.default.chromium.png | 3841 | Changed |
| vr-tests-react-components/Field.size-small.default.chromium.png | 3841 | Changed |
vr-tests-react-components/Menu Converged - submenuIndicator slotted content 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png | 404 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 897 | Changed |
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 44 | Changed |
vr-tests-react-components/ProgressBar converged 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 34 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png | 43 | Changed |
There were 1 duplicate changes discarded. Check the build logs for more information.
dmytrokirpa
marked this pull request as ready for review
July 25, 2026 16:13
Hotell
approved these changes
Jul 27, 2026
| }); | ||
|
|
||
| expect(result.current.input.value).toBe('test'); | ||
| expect(result.current.size).toBe('large'); |
Contributor
There was a problem hiding this comment.
q: is this expected behaviour in terms of design language consistency ? user can go wild and use various sizes between field/input ?
Contributor
Author
There was a problem hiding this comment.
From a design language point of view, I’m not sure this is behaving as expected. In the all controls implementation, context values act as defaults, and component props override them.
| const fieldControlProps = useFieldControlProps_unstable(props, { | ||
| supportsLabelFor: true, | ||
| supportsRequired: true, | ||
| supportsSize: true, |
Contributor
There was a problem hiding this comment.
with these changes is this prop dead API now ? it is still used in TagPickerInput, should we reflect these changes there as well ?
Contributor
Author
There was a problem hiding this comment.
it's not a dead API, it just doesn't make sense for base hooks as they shouldn't have style props (size/appearance/etc)
Contributor
Author
There was a problem hiding this comment.
I'll double check for TagPicker and other components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Field control size handling for Input and Textarea components
Changes
Packages affected
Beachball change files have been created for both packages.
Before (all inputs doesn't respect field size)
After (inputs respect field size)