Skip to content

fix(react-teaching-popover): isolate bundled dismiss icon - #36504

Merged
mainframev merged 1 commit into
microsoft:masterfrom
mainframev:fix/headless-teaching-popover-icon
Aug 5, 2026
Merged

fix(react-teaching-popover): isolate bundled dismiss icon#36504
mainframev merged 1 commit into
microsoft:masterfrom
mainframev:fix/headless-teaching-popover-icon

Conversation

@mainframev

@mainframev mainframev commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
  • move the behavior-only TeachingPopoverTitle state hook into an icon-free module
  • keep the styled bundleIcon default in useTeachingPopoverTitle_unstable
  • avoid pulling the bundled dismiss icon and Griffel into the headless TeachingPopover entrypoint
  • add focused tests, a bundle-size fixture, and patch change files

@mainframev
mainframev requested review from a team and Mitch-At-Work as code owners August 3, 2026 18:16
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-headless-components-preview
react-headless-components-preview: entire library
231.539 kB
66.883 kB
230.371 kB
66.427 kB
-1.168 kB
-456 B
react-headless-components-preview
@fluentui/react-headless-components-preview/teaching-popover
0 B
0 B
35.416 kB
11.745 kB
🆕 New entry
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
66.297 kB
19.006 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
226.106 kB
68.067 kB
react-components
react-components: FluentProvider & webLightTheme
39.52 kB
13.116 kB
react-components
react-components: entire library
1.295 MB
326.55 kB
react-portal-compat
PortalCompatProvider
5.341 kB
2.146 kB
react-teaching-popover
TeachingPopover
100.758 kB
31.829 kB
react-timepicker-compat
TimePicker
140.991 kB
46.069 kB
🤖 This report was generated against 9b50daf7d3e1d0b37733245f355ed087a6f21f79

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Pull request demo site: URL

@mainframev mainframev self-assigned this Aug 3, 2026

@Mitch-At-Work Mitch-At-Work left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TeachingPopover original functionality in-tact after structural changes

@mainframev
mainframev merged commit 1999fcd into microsoft:master Aug 5, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants