test(react-button): add SplitButton regression test before base-hook extraction - #36523
Open
mainframev wants to merge 1 commit into
Open
test(react-button): add SplitButton regression test before base-hook extraction#36523mainframev wants to merge 1 commit into
mainframev wants to merge 1 commit into
Conversation
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
mainframev
changed the title
mainframev
force-pushed
the
test/split-button-hook-regression-tests
branch
from
August 5, 2026 20:11
52c3b76 to
faba25f
Compare
…ook extraction Adds coverage for behavior that must not regress when useSplitButton_unstable is later split into a design-agnostic base hook plus a styled wrapper: - ref forwarding resolves to the root DIV element - the default styled MenuButton chevron still renders when no menuIcon is given - an explicit menuIcon still overrides the default chevron - resolved child slot element metadata points at the styled Button/MenuButton components (not just state.components) All added tests pass against the current (unmodified) useSplitButton_unstable implementation, confirming this is a pure safety net with no behavior change.
mainframev
force-pushed
the
test/split-button-hook-regression-tests
branch
from
August 5, 2026 20:18
faba25f to
ef09037
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Positioning 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 959 | Changed |
vr-tests-react-components/ProgressBar converged 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png | 44 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png | 25 | Changed |
| vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png | 175 | Changed |
vr-tests-react-components/TagPicker 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled.chromium.png | 677 | Changed |
| vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png | 658 | Changed |
There were 2 duplicate changes discarded. Check the build logs for more information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure regression-test safety net for the existing, unmodified
SplitButton/useSplitButton_unstablein@fluentui/react-button, added before any refactor. This is PR 1 of a 3-PR stack that extracts a design-agnosticuseSplitButtonBase_unstablebase hook and builds a headlessSplitButtonprimitive on top of it.Stack:
feat/split-button-base-hook—@fluentui/react-buttonbase-hook extraction (base: this branch)feat/split-button-headless— headlessSplitButtonin@fluentui/react-headless-components-preview(base: PR 2's branch)What changed
SplitButton.test.tsxcovering:DIVelementSLOT_ELEMENT_TYPE_SYMBOL) pointing at the styledButton/MenuButtonThese tests were verified to pass against
master's current, unmodifieduseSplitButton_unstablebefore any refactor was made — they are a pure safety net, not coupled to the upcoming refactor.