Preserve inline CSF3 story parameters in full-source preset - #36661
Merged
Dmytro Kirpa (dmytrokirpa) merged 7 commits intoSep 3, 2026
Merged
Conversation
Co-authored-by: dmytrokirpa <1492102+dmytrokirpa@users.noreply.github.com>
Co-authored-by: dmytrokirpa <1492102+dmytrokirpa@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix babel-preset-storybook-full-source overwriting CSF3 parameters
Preserve inline CSF3 story parameters in full-source preset
Aug 31, 2026
Dmytro Kirpa (dmytrokirpa)
left a comment
Contributor
There was a problem hiding this comment.
Copilot fix review comments
Co-authored-by: dmytrokirpa <1492102+dmytrokirpa@users.noreply.github.com>
Contributor
Author
Addressed in |
Dmytro Kirpa (dmytrokirpa)
approved these changes
Aug 31, 2026
Copilot started reviewing on behalf of
Dmytro Kirpa (dmytrokirpa)
September 1, 2026 10:27
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes parameter loss when augmenting typed CSF3 stories with fullSource.
Changes:
- Detects inline story parameters through TypeScript wrappers.
- Adds CSF2/CSF3 regression fixtures.
- Adds a patch change file.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/fullsource.ts |
Detects inline parameters. |
csf3-spread/output.js |
Preserves spread-story parameters. |
csf3-render-and-args/output.js |
Preserves args-only parameters. |
csf3-inline-parameters-typescript/code.tsx |
Adds typed CSF3 fixture. |
csf3-inline-parameters-typescript/output.js |
Verifies preserved metadata. |
csf3-inline-parameters-typescript/options.json |
Configures fixture output. |
csf2-storyfn-parameters-typescript/code.tsx |
Adds typed CSF2 fixture. |
csf2-storyfn-parameters-typescript/output.js |
Verifies CSF2 behavior. |
csf2-storyfn-parameters-typescript/options.json |
Configures fixture output. |
change/@fluentui-babel-preset-storybook-full-source-0d224dca-ee83-42af-95bf-9d09c643410b.json |
Records the patch release. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: dmytrokirpa <1492102+dmytrokirpa@users.noreply.github.com>
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
Martin Hochel (Hotell)
approved these changes
Sep 3, 2026
Martin Hochel (Hotell)
left a comment
Contributor
There was a problem hiding this comment.
1 cleanup suggestion otherwise LGTM
Dmytro Kirpa (dmytrokirpa)
approved these changes
Sep 3, 2026
Co-authored-by: dmytrokirpa <1492102+dmytrokirpa@users.noreply.github.com>
Dmytro Kirpa (dmytrokirpa)
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
babel-preset-storybook-full-sourcetreated CSF3 stories with inlineparametersas missing parameters, then appendedStory.parameters = {}before assigningfullSource. This dropped existing Storybook metadata such asdocs.description.story.Parameter detection
parameterson CSF3 object story exports.asandsatisfies.Regression coverage
Meta/StoryObjpattern.