docs: rename stringifyDataAttribute to toDataAttributeValue in headless docs - #36683
Open
Victor Genaev (mainframev) wants to merge 1 commit into
Open
Conversation
…ss docs The utility was renamed in react-headless-components-preview (microsoft#36596) but the headless-component skill and the headless components RFC still referenced the old name. Also corrects the RFC's description of the utility's return value: it returns '' when the attribute is present and undefined when omitted, not the strings "true"/"false".
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
Dmytro Kirpa (dmytrokirpa)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The
stringifyDataAttributeutility in@fluentui/react-headless-components-previewwas renamed totoDataAttributeValuein #36596, but two docs were left pointing at the old name:.agents/skills/headless-component/SKILL.md— the skill agents use to author headless primitivesdocs/react-v9/contributing/rfcs/react-components/convergence/headless-components.md— the headless components RFCNew Behavior
All references use
toDataAttributeValue.The RFC comment now matches the implementation: the utility returns
''when the attribute should be present andundefinedwhen it should be omitted. The old wording would have led consumers to write[data-disabled="true"]selectors that never match, since the attribute is emitted with an empty value.Docs-only, no change file needed.
Related Issue(s)