sync dev to stable#576
Merged
Merged
Conversation
…er models Run 28846102061 hit 'LLM API returned 400' for 90/91 templates. Auth and routing succeeded (not 401/404), so the request body was rejected — the classic newer-model (gpt-5.x / reasoning) incompatibility with the legacy chat-completions params. - Use max_completion_tokens instead of the legacy max_tokens (newer models 400 on max_tokens) - Omit temperature (several newer models only accept the default and 400 otherwise) - Bump the default api-version to 2024-10-21 (>= 2024-09-01-preview, required for max_completion_tokens) and make it overridable via AZURE_OPENAI_API_VERSION - Log a truncated response body on failure so the exact 400 reason is visible in CI instead of a bare status code
fix(sample-catalog): make LLM description request compatible with newer models
…ning models After #522 fixed the 400s, run 28846883377 still left 26/91 descriptions empty with no error in the log. The deployment is a reasoning model (gpt-5.x / o-series): LLM phase took ~8s/template, and such models spend the completion budget on hidden reasoning tokens BEFORE emitting content. With max_completion_tokens=800, ~1/4 of templates exhausted the budget on reasoning alone and returned EMPTY content (finish_reason=length). The empty-content branch (and the no-description branch) returned null WITHOUT warning, so the failures were invisible. - Raise the default budget to 2000 tokens (output is one sentence; headroom is cheap), overridable via AZURE_OPENAI_MAX_COMPLETION_TOKENS - Add optional AZURE_OPENAI_REASONING_EFFORT (only sent when set, since non-reasoning models 400 on it) to cap hidden reasoning for this trivial task - Emit a diagnostic warning (with finish_reason and reasoning_tokens) instead of silently returning null, for both the empty-content and missing-description paths
This reverts commit 338309c.
Adds PINNED_TEMPLATE_PATHS and reorderPinnedFirst so the generated sample-catalog.json lists the framework hello-world and most-requested samples first. Gallery order is now controlled entirely by the catalog JSON.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.