Implement VSETATTR - #2001
Merged
Merged
Conversation
19 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Redis-compatible VSETATTR support for Vector Sets, including the “read-modeled write” replication/AOF handling needed for DiskANN-backed indexes, and new standalone + cluster coverage.
Changes:
- Implements Vector Set attribute updates via DiskANN, including synthetic replication RMW injection and AOF replay handling.
- Extends storage-function handling to account for
VSETATTRreplication/CU paths and related command plumbing. - Adds standalone and cluster tests for
VSETATTR, plus bumps thediskann-garnetdependency.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/standalone/Garnet.test.vectorset/RespVectorSetTests.cs | Adds VSETATTR async behavior test and hooks into interrupted-delete fault injection coverage. |
| test/cluster/Garnet.test.cluster.vectorsets/VectorSets/ClusterVectorSetTests.cs | Adds a cluster replication test validating VSETATTR replays to a replica. |
| libs/server/Storage/Session/MainStore/VectorStoreOps.cs | Implements VectorSetSetAttribute flow and triggers manual replication on success. |
| libs/server/Storage/Functions/MainStore/VarLenInputMethods.cs | Updates vector CU sizing condition (but needs VSETATTR handling for correct sizing). |
| libs/server/Storage/Functions/MainStore/RMWMethods.cs | Adds VSETATTR handling to in-place and copy-update paths for synthetic replication writes. |
| libs/server/Storage/Functions/MainStore/PrivateMethods.cs | Includes VSETATTR in RESP copy paths for the main store functions. |
| libs/server/Resp/Vector/VectorManager.Replication.cs | Adds synthetic replication injection + replica-side replay handler for VSETATTR. |
| libs/server/Resp/Vector/VectorManager.cs | Adds replication-log arg sentinel and implements TrySetAttribute. |
| libs/server/Resp/Vector/DiskANNService.cs | Adds managed wrapper calling native set_attribute. |
| libs/server/AOF/AofProcessor.cs | Routes replayed VSETATTR synthetic RMW records through the VectorManager replica handler. |
| Directory.Packages.props | Bumps diskann-garnet package version. |
tiagonapoli
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
VSETATTR.Standard subtleties around these writes being modeled as reads, and one diskann-garnet defect fixed around attribute removal.