Update Vector Sets docs to reflect current main behavior - #2103
Merged
Badrish Chandramouli (badrishc) merged 1 commit intoSep 4, 2026
Conversation
Cherry-picks the subset of doc changes from #1992 that are already true on main: - Remove the outdated ~15 concurrent Vector Sets cap (Cluster + Limits); the real limit is uint.MaxValue contexts / ContextStep(8) ~ 500 million. - Use XU8/XI8 input form tokens (XB8 remains a backwards-compat alias). - Document the supported quantizers (NOQUANT, Q8, BIN, XNOQUANT_U8/I8, XBIN_U8/I8) with Q8 as the default; drop the stale 'Q8/BIN rejected' and 'default Q8 fails' notes. - Drop VCARD and VISMEMBER from 'Not Yet Implemented' (both are functional on main). VLINKS and VRANDMEMBER remain listed since they are still +OK stubs on main. Excludes the FFI/dev-doc changes from #1992, which correspond to unmerged code (logCallback, valueLengthHint, search_neighbors, random_members, etc.). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Badrish Chandramouli (badrishc)
September 4, 2026 20:58
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Input tokens, REDUCE restrictions, and the maximum Vector Set count remain inaccurate.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates Vector Sets documentation to reflect current command behavior.
Changes:
- Documents current vector formats and quantizers.
- Updates command implementation status.
- Revises the concurrent Vector Set limit.
File summaries
| File | Description |
|---|---|
website/docs/commands/vector-sets.md |
Updates Vector Set syntax, quantization, command status, and limits. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kevin-montrose
approved these changes
Sep 4, 2026
Badrish Chandramouli (badrishc)
deleted the
badrishc/update-vector-set-docs
branch
September 4, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the outdated Vector Sets command documentation to match the current behavior on
main.This is a docs-only PR. It cherry-picks the subset of doc changes from the draft #1992 that are already true on
main, and deliberately excludes the parts of that draft that depend on its unmerged code.Included (verified against
main)uint.MaxValuecontexts /ContextStep(8) ≈ 500 million (VectorManager.cs,VectorManager.ContextMetadata.cs).XU8/XI8(XB8remains a backwards-compat alias in the parser).NOQUANT,Q8,BIN,XNOQUANT_U8,XNOQUANT_I8,XBIN_U8,XBIN_I8— withQ8as the default. Dropped the stale "Q8/BIN rejected" and "default Q8 fails" notes. TheXNOQUANT_*/XBIN_*variants are correctly noted as incompatible withREDUCE(RespServerSessionVectors.cs).VCARDandVISMEMBERfrom "Not Yet Implemented" — both are fully functional onmain.Deliberately excluded (not true on
main)VLINKSandVRANDMEMBERremain in "Not Yet Implemented" — they are still// TODO: implement!stubs that return+OKonmain.dev/vector-sets.mdFFI changes from Update DiskANN FFI #1992 (e.g.logCallback,valueLengthHint,search_neighbors,random_members,beam_width, in-place filter callback) correspond to that PR's unmerged code and are not present onmain.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com