Skip to content

build(deps): bump golang.org/x/net from 0.50.0 to 0.51.0 in /eng/_util#2162

Closed
dependabot[bot] wants to merge 1 commit intomicrosoft/mainfrom
dependabot/go_modules/eng/_util/golang.org/x/net-0.51.0
Closed

build(deps): bump golang.org/x/net from 0.50.0 to 0.51.0 in /eng/_util#2162
dependabot[bot] wants to merge 1 commit intomicrosoft/mainfrom
dependabot/go_modules/eng/_util/golang.org/x/net-0.51.0

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 26, 2026

Bumps golang.org/x/net from 0.50.0 to 0.51.0.

Commits
  • 60b3f6f internal/http3: prevent Server handler from writing longer body than declared
  • b0ca456 internal/http3: fix Write in Server Handler returning the wrong value
  • 1558ba7 publicsuffix: update to 2026-02-06
  • 4e1c745 internal/http3: make Server response include headers that can be inferred
  • 19f580f http2: fix nil panic in typeFrameParser for unassigned frame types
  • 818aad7 internal/http3: add server to client trailer header support
  • c1bbe1a internal/http3: add client to server trailer header support
  • 29181b8 all: remove go1.25 and older build constraints
  • 8109305 all: upgrade go directive to at least 1.25.0 [generated]
  • 0b37bdf quic: don't run TestStreamsCreateConcurrency in synctest bubble
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Feb 26, 2026
@dependabot dependabot bot requested a review from a team as a code owner February 26, 2026 10:23
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Feb 26, 2026
@gdams gdams enabled auto-merge (squash) February 26, 2026 10:29
@gdams
Copy link
Member

gdams commented Feb 26, 2026

MingW install steps are failing:

C:\Users\cloudtest\go\pkg\mod\golang.org\toolchain@v0.0.1-go1.25.0.windows-amd64\src\runtime\alg.go:8:2: could not import internal/abi (object is [go object windows amd64 go1.25.0 GOAMD64=v1 X:systemcrypto,regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
] expected [go object windows amd64 go1.25.0 GOAMD64=v1 X:regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
])
C:\Users\cloudtest\go\pkg\mod\golang.org\toolchain@v0.0.1-go1.25.0.windows-amd64\src\runtime\alg.go:9:2: could not import internal/byteorder (object is [go object windows amd64 go1.25.0 GOAMD64=v1 X:systemcrypto,regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
] expected [go object windows amd64 go1.25.0 GOAMD64=v1 X:regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
])
C:\Users\cloudtest\go\pkg\mod\golang.org\toolchain@v0.0.1-go1.25.0.windows-amd64\src\runtime\alg.go:10:2: could not import internal/cpu (object is [go object windows amd64 go1.25.0 GOAMD64=v1 X:systemcrypto,regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
] expected [go object windows amd64 go1.25.0 GOAMD64=v1 X:regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
])
C:\Users\cloudtest\go\pkg\mod\golang.org\toolchain@v0.0.1-go1.25.0.windows-amd64\src\runtime\alg.go:11:2: could not import internal/goarch (object is [go object windows amd64 go1.25.0 GOAMD64=v1 X:systemcrypto,regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
] expected [go object windows amd64 go1.25.0 GOAMD64=v1 X:regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
])
C:\Users\cloudtest\go\pkg\mod\golang.org\toolchain@v0.0.1-go1.25.0.windows-amd64\src\runtime\alg.go:12:2: could not import internal/runtime/sys (object is [go object windows amd64 go1.25.0 GOAMD64=v1 X:systemcrypto,regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
] expected [go object windows amd64 go1.25.0 GOAMD64=v1 X:regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
])
C:\Users\cloudtest\go\pkg\mod\golang.org\toolchain@v0.0.1-go1.25.0.windows-amd64\src\runtime\arena.go:88:2: could not import internal/runtime/atomic (object is [go object windows amd64 go1.25.0 GOAMD64=v1 X:systemcrypto,regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
] expected [go object windows amd64 go1.25.0 GOAMD64=v1 X:regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
])
C:\Users\cloudtest\go\pkg\mod\golang.org\toolchain@v0.0.1-go1.25.0.windows-amd64\src\runtime\arena.go:89:2: could not import internal/runtime/math (object is [go object windows amd64 go1.25.0 GOAMD64=v1 X:systemcrypto,regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
] expected [go object windows amd64 go1.25.0 GOAMD64=v1 X:regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
])
C:\Users\cloudtest\go\pkg\mod\golang.org\toolchain@v0.0.1-go1.25.0.windows-amd64\src\runtime\covercounter.go:8:2: could not import internal/coverage/rtcov (object is [go object windows amd64 go1.25.0 GOAMD64=v1 X:systemcrypto,regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
] expected [go object windows amd64 go1.25.0 GOAMD64=v1 X:regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
])
C:\Users\cloudtest\go\pkg\mod\golang.org\toolchain@v0.0.1-go1.25.0.windows-amd64\src\runtime\error.go:9:2: could not import internal/bytealg (object is [go object windows amd64 go1.25.0 GOAMD64=v1 X:systemcrypto,regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
] expected [go object windows amd64 go1.25.0 GOAMD64=v1 X:regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
])
C:\Users\cloudtest\go\pkg\mod\golang.org\toolchain@v0.0.1-go1.25.0.windows-amd64\src\runtime\extern.go:305:2: could not import internal/goos (object is [go object windows amd64 go1.25.0 GOAMD64=v1 X:systemcrypto,regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
] expected [go object windows amd64 go1.25.0 GOAMD64=v1 X:regabiwrappers,regabiargs,aliastypeparams,swissmap,synchashtriemap,dwarf5
])
C:\Users\cloudtest\go\pkg\mod\golang.org\toolchain@v0.0.1-go1.25.0.windows-amd64\src\runtime\extern.go:305:2: too many errors

@dagood
Copy link
Member

dagood commented Feb 26, 2026

Looks like the go.mod toolchain update brings in an official version of Go that matches up with what we use for our build, and the match caused the exact cache collision I was hitting that we applied a fix for in #1994 for 1.26.

The root cause though is that we're using the ambient Go. We should install the mingw installation tool using the Go toolset installed by eng/run.ps1 etc.

go install github.com/microsoft/go-infra/cmd/getmingw

@dagood dagood disabled auto-merge February 26, 2026 19:42
@dagood
Copy link
Member

dagood commented Feb 26, 2026

I'll make a fix for that.

@dagood
Copy link
Member

dagood commented Feb 27, 2026

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 27, 2026

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@dagood
Copy link
Member

dagood commented Feb 27, 2026

@dependabot recreate

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.50.0 to 0.51.0.
- [Commits](golang/net@v0.50.0...v0.51.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.51.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/eng/_util/golang.org/x/net-0.51.0 branch from ba76ca6 to cc894df Compare February 27, 2026 22:41
@gdams
Copy link
Member

gdams commented Feb 27, 2026

We'll need to bump the golanglint docker image version again

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 27, 2026

Looks like golang.org/x/net is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Feb 27, 2026
@dependabot dependabot bot deleted the dependabot/go_modules/eng/_util/golang.org/x/net-0.51.0 branch February 27, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants