Fix builds: Remove vpmem multimapping annotation from parity tests - #2722
Merged
Conversation
…ermutations tests Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
jiechen0826
approved these changes
May 6, 2026
anmaxvl
approved these changes
May 6, 2026
helsaawy
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2 LCOW builder explicitly rejects the
io.microsoft.virtualmachine.lcow.vpmem.nomultimappingannotation inprocessAnnotations(internal/builder/vm/lcow/specs.go) as not yet implemented, butTestLCOWSandboxOptionsFieldParityNonDefaultset it in two cases.buildV2LCOWDocumenttherefore always failed with"...vpmem.nomultimapping annotation is not supported", making the parent test permanently red in CI without verifying any real parity.Removed the standalone "VPMem no multi-mapping" case and drop the annotation from "all sandbox options non-default". The intentional v2 rejection is still covered by the unit test in
internal/builder/vm/lcow/specs_test.go.