Skip to content

Added flags field to Network Subnets - #21

Merged
princepereira merged 1 commit into
microsoft:mainfrom
daschott:user/daschott/subnetflags
Oct 1, 2025
Merged

Added flags field to Network Subnets#21
princepereira merged 1 commit into
microsoft:mainfrom
daschott:user/daschott/subnetflags

Conversation

@daschott

@daschott daschott commented Sep 16, 2025

Copy link
Copy Markdown
Collaborator

Subnets have a flags field that is needed to fix issue for network rehydration when GatewayAddress == ManagementIP.

Customers need to be able to use the Flag "DoNotReserveGatewayAddress" in order to support rehydration for the above scenario.

@daschott
daschott marked this pull request as ready for review September 16, 2025 20:52
@daschott

Copy link
Copy Markdown
Collaborator Author

Have tested this change and verified it can be used to resolve the issue

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for subnet flags to enable proper network rehydration when the gateway address equals the management IP. This addresses a specific customer scenario where the "DoNotReserveGatewayAddress" flag is needed for successful network rehydration.

Key changes:

  • Introduces SubnetFlags type and constants for flag management
  • Adds a Flags field to the Subnet struct to support subnet-level configuration options

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread hcn/hcnnetwork.go Outdated
@princepereira

Copy link
Copy Markdown
Collaborator

KubeProxy is currently the only consumer of hnslib. The long-term plan is to deprecate the hcn code in hcsshim and migrate it to hnslib, but that transition will take some time. Until then, any hcn changes added to hnslib should also be reflected in hcsshim and vice-versa.

@daschott

Copy link
Copy Markdown
Collaborator Author

KubeProxy is currently the only consumer of hnslib. The long-term plan is to deprecate the hcn code in hcsshim and migrate it to hnslib, but that transition will take some time. Until then, any hcn changes added to hnslib should also be reflected in hcsshim and vice-versa.

Equivalent hcsshim PR: microsoft/hcsshim#2525

@sbangari sbangari self-assigned this Sep 30, 2025
@princepereira
princepereira merged commit 23ab7d6 into microsoft:main Oct 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants