Skip to content

feat(scripts): add dynamic Python skill discovery for lint/test#957

Merged
WilliamBerryiii merged 14 commits intomicrosoft:mainfrom
JasonOA888:npm-scripts-python-dynamic
Mar 14, 2026
Merged

feat(scripts): add dynamic Python skill discovery for lint/test#957
WilliamBerryiii merged 14 commits intomicrosoft:mainfrom
JasonOA888:npm-scripts-python-dynamic

Conversation

@JasonOA888
Copy link
Contributor

Implements dynamic discovery of Python skills by finding all pyproject.toml files and running ruff/pytest on each.

Motivation

As the project grows to support more Python skills, we need a way to automatically discover and lint/test all of them without manually updating npm scripts.

Changes

New Scripts

scripts/linting/
├── Invoke-PythonLint.ps1    # Discovers Python skills, runs ruff
└── Invoke-PythonTests.ps1   # Discovers Python skills, runs pytest

How It Works

  1. Scans repository for pyproject.toml files (excludes node_modules)
  2. For each Python skill:
    • lint:py runs ruff check
    • test:py runs pytest (if tests/ directory exists)
  3. Reports summary of passed/failed skills

Example Output

Found 3 Python skill(s):
  - ./skills/my-python-skill
  - ./skills/another-skill
  
Running ruff in ./skills/my-python-skill...
✓ No linting issues

Running ruff in ./skills/another-skill...
❌ Linting issues found

❌ Linting completed with errors

package.json

{
  "lint:py": "pwsh -NoProfile -File ./scripts/linting/Invoke-PythonLint.ps1",
  "test:py": "pwsh -NoProfile -File ./scripts/linting/Invoke-PythonTests.ps1"
}

Benefits

  • Automatic discovery: New Python skills are automatically included
  • Cross-platform: PowerShell scripts work on Windows/Linux/macOS
  • Clear output: Shows which skills passed/failed
  • Fail-fast: Returns non-zero exit code on any failure

Testing

  • Tested with multiple pyproject.toml files
  • Handles missing ruff/pytest gracefully
  • Excludes node_modules correctly

Addresses feedback from #933

Closes #933

Implements dynamic discovery of Python skills by finding all
pyproject.toml files and running ruff/pytest on each.

## Changes

- Add Invoke-PythonLint.ps1 - discovers Python skills and runs ruff
- Add Invoke-PythonTests.ps1 - discovers Python skills and runs pytest
- Update package.json scripts:
  - lint:py -> uses Invoke-PythonLint.ps1
  - test:py -> uses Invoke-PythonTests.ps1

## How it works

1. Scans repository for pyproject.toml files (excludes node_modules)
2. For each Python skill directory:
   - lint:py runs ruff check
   - test:py runs pytest (if tests/ exists)
3. Reports summary of passed/failed skills

## Example output

```
Found 3 Python skill(s):
  - ./skills/my-python-skill
  - ./skills/another-skill

Running ruff in ./skills/my-python-skill...
✓ No linting issues

Running ruff in ./skills/another-skill...
❌ Linting issues found

❌ Linting completed with errors
```

Addresses feedback from microsoft#933
@WilliamBerryiii
Copy link
Member

Hey @JasonOA888 — thanks for tackling #933! A few things I wanted to call out that the review comments don't fully capture:

What this PR does well:

  • The pyproject.toml discovery pattern is exactly the right approach. It mirrors how CI and the devcontainer already locate Python skills, so new skills get picked up automatically without manual script updates.
  • The structured output with pass/fail summaries and emoji indicators makes it easy to scan results at a glance.
  • The Push-Location / Pop-Location / finally pattern (intent-wise) is the correct way to handle directory changes safely in PowerShell.
  • Error handling with exit codes is clean and CI-friendly.

Quick orientation for the convention items:
The review has several "align with sibling scripts" comments. The easiest way to address all of them at once is to use Invoke-PSScriptAnalyzer.ps1 as your template — it has the full pattern with copyright header, CmdletBinding, params, region blocks, shared module imports, and the main execution guard. Invoke-YamlLint.ps1 is another good reference with a simpler structure.

On the uv vs pip item:
This one might not be obvious if you haven't seen the CI configuration. The project uses uv (by Astral, the same team behind ruff) for Python environment management. Both copilot-setup-steps.yml and the devcontainer's on-create.sh run find .github/skills -name pyproject.toml -execdir uv sync \; to pre-install dependencies. So by the time these scripts run, ruff and pytest should already be available through each skill's pyproject.toml. The auto-install fallback is a nice thought, but pip can conflict with uv-managed environments.

Let me know if any of the review feedback is unclear — happy to pair on the changes or answer questions. Looking forward to the next iteration! 🚀

## Changes

### Invoke-PythonLint.ps1
- Add copyright header (Microsoft standard)
- Add [CmdletBinding()] and param() block with RepoRoot/OutputPath
- Remove double Pop-Location bug in no-tests case
- Replace pip with uv pip (project standard)
- Add region blocks for consistency

### Invoke-PythonTests.ps1
- Add copyright header
- Add [CmdletBinding()] and param() block
- Remove explicit Pop-Location (let finally handle it)
- Replace pip with uv pip
- Add region blocks and main execution guard
- Add Verbosity parameter

### package.json
- Update lint:py to use Invoke-PythonLint.ps1
- Add lint:py to lint:all chain

Fixes review feedback from PR microsoft#957
@JasonOA888 JasonOA888 force-pushed the npm-scripts-python-dynamic branch from bcc215c to 7946ae6 Compare March 10, 2026 00:50
JasonOA888 and others added 8 commits March 10, 2026 08:53
## Changes

### Style
- Use single quotes for non-interpolated strings (project convention)
- Align with Invoke-PSScriptAnalyzer.ps1 template structure
- Add Author header

### Performance
- Move pytest availability check outside loop (mirrors ruff check pattern)

### Consistency
- Both scripts now follow same structure:
  - Copyright header
  - [CmdletBinding()] and param()
  - #region Functions / #endregion
  - #region Main Execution / #endregion
  - .InvocationName guard
Per PR review feedback, Python linting should run alongside other linters.
- Use double-quoted strings for backtick-n escape sequences in
  Invoke-PythonLint.ps1 and Invoke-PythonTests.ps1
- Add #endregion Main Execution label and remove orphan #endregion
  in Invoke-PythonTests.ps1
- Add UTF-8 BOM encoding to both scripts for non-ASCII characters
- Document lint:py, test:py, and updated lint:all in
  copilot-instructions.md
- Add Invoke-PythonLint.Tests.ps1 covering tool availability, skill
  discovery, lint execution, and output persistence
- Add Invoke-PythonTests.Tests.ps1 covering tool availability, skill
  discovery, test execution, failure handling, and output persistence
- 30 tests total covering ruff/pytest integration paths
- fix E501 line-too-long in render_pdf_images.py, test_build_deck.py, test_render_pdf_images.py
- fix I001 import sort order in test_render_pdf_images.py
- add .ruff_cache/ to .gitignore

🐍 - Generated by Copilot
- add Test-PythonSkillConfig function validating ruff, pytest, and dev dependency config
- integrate pyproject.toml checks into Test-SkillDirectory pipeline
- add 6 Pester tests covering validation scenarios

🔍 - Generated by Copilot
- replace unix shell stub with .cmd batch file on Windows for python mock
- document Python skill pyproject.toml validation in copilot-instructions

🔧 - Generated by Copilot
@WilliamBerryiii WilliamBerryiii dismissed their stale review March 13, 2026 21:54

Dismissing my own review and passing to a peer because of the extra changes

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 86.61972% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.03%. Comparing base (f4deda7) to head (9da47fd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scripts/linting/Invoke-PythonTests.ps1 81.81% 12 Missing ⚠️
scripts/linting/Invoke-PythonLint.ps1 87.03% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
+ Coverage   86.01%   86.03%   +0.01%     
==========================================
  Files          28       30       +2     
  Lines        5270     5412     +142     
==========================================
+ Hits         4533     4656     +123     
- Misses        737      756      +19     
Flag Coverage Δ
pester 86.03% <86.61%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scripts/linting/Validate-SkillStructure.ps1 96.00% <100.00%> (+0.43%) ⬆️
scripts/linting/Invoke-PythonLint.ps1 87.03% <87.03%> (ø)
scripts/linting/Invoke-PythonTests.ps1 81.81% <81.81%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Replace four em-dash characters in the Coding Agent Environment section
that caused markdown lint failures (MD058/blanks-around-fences).
@WilliamBerryiii WilliamBerryiii force-pushed the npm-scripts-python-dynamic branch from 2e8d308 to 5a4ade6 Compare March 13, 2026 22:25
@WilliamBerryiii
Copy link
Member

Hey @JasonOA888 — huge thank you for putting this together! 🎉

The dynamic Python skill discovery is exactly the kind of infrastructure improvement that pays dividends as the project grows. Really appreciate the thoughtfulness here: automatic pyproject.toml scanning, clean summary output, graceful handling of missing tools, and solid cross-platform support. The attention to detail shows.

We took it from here and got it merged. Your contribution makes life easier for everyone adding Python skills going forward.

Thanks again for the time and effort — looking forward to more contributions from you! 🙌

@WilliamBerryiii WilliamBerryiii merged commit 0a90f57 into microsoft:main Mar 14, 2026
29 checks passed
WilliamBerryiii added a commit that referenced this pull request Mar 20, 2026
🤖 I have created a release *beep* *boop*
---


##
[3.2.0](hve-core-v3.1.46...hve-core-v3.2.0)
(2026-03-20)


### ✨ Features

* add -OutputPath parameter to Validate-MarkdownFrontmatter.ps1
([#1134](#1134))
([fdf1bcf](fdf1bcf)),
closes [#1006](#1006)
* add action version consistency scan workflow
([#1127](#1127))
([4229df1](4229df1))
* **agent:** MVE Experiment Designer
([#976](#976))
([70f86ca](70f86ca))
* **agents:** add ADO Backlog Manager orchestrator agent
([#800](#800))
([fae3987](fae3987))
* **agents:** add meeting analyst agent for transcript analysis using
work-iq ([#502](#502))
([5345b5b](5345b5b))
* **agents:** add quick-reference line to RPI Phase 5 suggestions
([#897](#897))
([9a90f39](9a90f39))
* **agents:** add RAI Planner, enhance SSSC Planner, and redesign
Security Planner
([#979](#979))
([06f826c](06f826c))
* **agents:** add symmetric cross-system handoff to GitHub Backlog
Manager ([#952](#952))
([ba34a35](ba34a35))
* **agents:** Functional Code Review Agent — pre-PR functional
correctness reviewer
([#733](#733))
([9cf63b7](9cf63b7))
* **build:** add Python extensions and uv 0.10.8 to devcontainer
([#920](#920))
([9ca0579](9ca0579))
* **build:** add uv ecosystem to Dependabot configuration
([#913](#913))
([2a4bd39](2a4bd39))
* **build:** enable npm pinning enforcement in dependency scan
([#838](#838))
([4e9e31f](4e9e31f))
* **build:** migrate attestation actions to v4.1.0 and add SBOM
verification docs
([#841](#841))
([ca1e65b](ca1e65b))
* **collections:** add four new validator checks (orphan, duplicate,
companion, coverage)
([#869](#869))
([1a96b73](1a96b73))
* **devcontainer,security:** add enterprise artifact hub configuration
([#1032](#1032))
([1d56d25](1d56d25))
* **docs:** add Rust coding standards and guidelines
([#809](#809))
([d4c4899](d4c4899))
* **extension:** add Microsoft logo icon to VS Code Marketplace listings
([#906](#906))
([82aca41](82aca41))
* **github:** add declarative label management
([#953](#953))
([a1a6845](a1a6845))
* **instructions:** add ADO backlog shared infrastructure
([#786](#786))
([1914078](1914078))
* **instructions:** add ADO backlog sprint planning and capacity
tracking ([#788](#788))
([d6fb77d](d6fb77d))
* **instructions:** add ADO triage workflow and prompt
([#787](#787))
([cde0190](cde0190))
* **instructions:** add shared story quality conventions and sprint
planning ([#803](#803))
([a2f18e3](a2f18e3))
* **prompts:** add ADO discovery and work item prompts with agent
routing ([#790](#790))
([7e74523](7e74523))
* **prompts:** add security review prompts
([#1118](#1118))
([ad30967](ad30967))
* **scripts:** add dynamic Python skill discovery for lint/test
([#957](#957))
([0a90f57](0a90f57))
* **scripts:** add Get-StandardTimestamp utility to CIHelpers module
([#1126](#1126))
([b273a4b](b273a4b))
* **scripts:** add Python copyright header validation
([#905](#905))
([67df902](67df902))
* **scripts:** add Python skill support to Validate-SkillStructure
([#903](#903))
([68479d9](68479d9))
* **scripts:** add workflow npm command scanning to dependency pinning
([#837](#837))
([6b5ae06](6b5ae06))
* **security:** add basic security reviewer agent with owasp skills
([#1008](#1008))
([cb1fd05](cb1fd05))
* **security:** add sigstore attestation bundles and fix
component-detection action
([#1148](#1148))
([f79c272](f79c272))
* **skills:** add Atheris fuzz harness with CI workflow integration
([#1102](#1102))
([d337e1d](d337e1d))
* **skills:** add PowerPoint automation skill with YAML-driven deck
generation ([#868](#868))
([00465cd](00465cd))
* **skills:** convert hve-core-installer agent to self-contained skill
([#846](#846))
([1d821fb](1d821fb))
* **skills:** enhance pr-reference skill with flexible filtering and
base branch detection
([#1095](#1095))
([26a32ea](26a32ea))
* **workflows:** add devcontainer infrastructure change log workflow
([#899](#899))
([8aca446](8aca446))
* **workflows:** add milestone auto-close on stable and pre-release
publishes ([#834](#834))
([79362b1](79362b1))
* **workflows:** add ms.date documentation freshness checking
([#969](#969))
([3ed441c](3ed441c))
* **workflows:** add Python linting CI workflow with Ruff
([#951](#951))
([f89f0eb](f89f0eb))
* **workflows:** add Python testing CI workflow with pytest and Codecov
([#934](#934))
([5e8306f](5e8306f))
* **workflows:** add uv and Python package sync to copilot-setup-steps
([#921](#921))
([45d517d](45d517d))


### 🐛 Bug Fixes

* **build:** override Linguist vendored flag for Python skill files
([#1155](#1155))
([0eee5b6](0eee5b6))
* **build:** override serialize-javascript to &gt;=7.0.3 for RCE fix
([#876](#876))
([e49039a](e49039a))
* **build:** resolve Pinned-Dependencies alerts for vsce npm commands in
extension workflows
([#782](#782))
([89dad9d](89dad9d))
* **build:** update undici and yauzl overrides for security audit
([#1030](#1030))
([2c2f92f](2c2f92f))
* **docs:** add CLI Plugins to install.md navigation surfaces
([#902](#902))
([79d6595](79d6595))
* **docs:** add sidebar ordering for Design Thinking documentation
([#832](#832))
([551fddc](551fddc)),
closes [#830](#830)
* **docs:** graduate design-thinking to preview and correct stale
collection references
([#831](#831))
([5110e35](5110e35))
* **docs:** include project-planning in UX Designer install guidance
([#908](#908))
([e7aa9bc](e7aa9bc))
* **docs:** remediate writing-style convention violations
([#865](#865))
([68b04bc](68b04bc))
* **docs:** remove draft content announcement banner
([#825](#825))
([b45de80](b45de80))
* **docs:** remove unbounded path-to-regexp override breaking SSG
([#1153](#1153))
([d810018](d810018))
* **docs:** use actual clone paths instead of folder display names in
multi-root workspace settings
([#984](#984))
([5dbab82](5dbab82))
* **instructions:** replace black with ruff in uv-projects
([#898](#898))
([b0c06d9](b0c06d9))
* **scripts:** cover .github/ skill files in copyright header validation
([#1055](#1055))
([#1098](#1098))
([27fbd33](27fbd33))
* **scripts:** eliminate phantom git changes from plugin generation
([#1035](#1035))
([e49a1b5](e49a1b5))
* **scripts:** enable JSON log output for lint:version-consistency
([#1033](#1033))
([52b0885](52b0885))
* **security:** calculate compliance score from total scanned
dependencies ([#930](#930))
([c112c3d](c112c3d))
* **skills:** add AST validation and namespace restriction for
content-extra.py
([#1027](#1027))
([c50c7a3](c50c7a3))
* **skills:** add depth limits to recursive PowerPoint processing
functions ([#1028](#1028))
([bf08994](bf08994))
* **skills:** harden XML parsing and blob writes in powerpoint extract
([#1053](#1053))
([89d24b1](89d24b1))
* **skills:** resolve ruff lint and format violations in powerpoint
skill ([#1048](#1048))
([17bbe7a](17bbe7a))
* **workflows:** add uv.lock dependencies submission have fork-skip
condition ([#1109](#1109))
([dec56ac](dec56ac))
* **workflows:** automate weekly SHA staleness check with issue creation
([#975](#975))
([1ea4caa](1ea4caa))
* **workflows:** close Codecov integration gaps for Pester and pytest
flags ([#1106](#1106))
([cca29b7](cca29b7))
* **workflows:** propagate uv sync errors in copilot-setup-steps
([#961](#961))
([df88d7c](df88d7c))
* **workflows:** resolve release-please skip cascade and Python project
discovery ([#1043](#1043))
([79993e2](79993e2))
* **workflows:** scan only commit subjects for breaking change detection
([#1157](#1157))
([a38a657](a38a657))


### 📚 Documentation

* clarify HVE Core Extension vs Installer messaging across documentation
([#965](#965))
([0fceb8f](0fceb8f))
* **docs:** add ADO integration user documentation
([#935](#935))
([ec89302](ec89302))
* **docs:** add Project Planning agent documentation
([#936](#936))
([3a3a0fd](3a3a0fd))
* **onboarding:** overhaul marketplace onboarding and documentation site
([#982](#982))
([4309e10](4309e10))


### ♻️ Refactoring

* **build:** merge code-review collection into coding-standards
([#863](#863))
([8027e7b](8027e7b))
* **workflows:** rename release pipeline workflows and add marketplace
automation triggers
([#829](#829))
([b6397f4](b6397f4))


### 🔧 Maintenance

* **build:** add clean:logs npm script
([#1122](#1122))
([f85fe02](f85fe02)),
closes [#988](#988)
* **build:** add JSON reporter for cspell
([#1123](#1123))
([6d59f67](6d59f67))
* **ci:** add multi-arch support to copilot-setup-steps binary downloads
([#955](#955))
([8d0c706](8d0c706))
* **deps-dev:** bump cspell from 9.6.4 to 9.7.0 in the npm-dependencies
group ([#839](#839))
([3fa16ff](3fa16ff))
* **deps:** bump actions/dependency-review-action from 4.8.3 to 4.9.0 in
the github-actions group across 1 directory
([#942](#942))
([1a9b858](1a9b858))
* **deps:** bump cairosvg from 2.8.2 to 2.9.0 in
/.github/skills/experimental/powerpoint
([#1025](#1025))
([f4deda7](f4deda7))
* **deps:** bump dompurify from 3.3.1 to 3.3.2 in /docs/docusaurus
([#924](#924))
([d2060d6](d2060d6))
* **deps:** bump svgo from 3.3.2 to 3.3.3 in /docs/docusaurus
([#880](#880))
([6dc2406](6dc2406))
* **deps:** bump the github-actions group across 1 directory with 4
updates ([#1100](#1100))
([2290dc0](2290dc0))
* **deps:** bump the github-actions group with 6 updates
([#840](#840))
([f57bc01](f57bc01))
* **docs:** correct New-MsDateReport table rendering and refresh stale
docs ([#1114](#1114))
([c2b806f](c2b806f))
* **settings:** remove orphaned Checkov config and stale gitignore
entries ([#870](#870))
([98fcd74](98fcd74))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: hve-core-release-please[bot] <254602402+hve-core-release-please[bot]@users.noreply.github.com>
Co-authored-by: Bill Berry <wberry@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants