configuration: define scope accessibility and add applicationScopes#177
Merged
hongchaodeng merged 2 commits intooam-dev:masterfrom Oct 8, 2019
Merged
configuration: define scope accessibility and add applicationScopes#177hongchaodeng merged 2 commits intooam-dev:masterfrom
applicationScopes#177hongchaodeng merged 2 commits intooam-dev:masterfrom
Conversation
hongchaodeng
requested review from
mikkelhegn,
technosophos and
vturecek
as code owners
Member
Author
|
@mikkelhegn @technosophos @suhuruli @vturecek This shall go into 1.0.0-alpha milestone and make the docs explicit. |
vturecek
approved these changes
Oct 2, 2019
Comment on lines
+342
to
+358
|
|
||
| ```yaml | ||
| apiVersion: core.hydra.io/v1alpha1 | ||
| kind: ApplicationConfiguration | ||
| metadata: | ||
| name: my-vpc-network | ||
| spec: | ||
| variables: | ||
| - name: networkName | ||
| value: "my-vpc" | ||
| scopes: | ||
| - name: myNetworkScope | ||
| type: core.hydra.io/v1alpha1.Network | ||
| properties: | ||
| - name: networkName | ||
| value: "[fromVariable(networkName)]" | ||
| --- |
Member
There was a problem hiding this comment.
I like this. Showing scopes in a separate app config file from the component instances is a good idea. It's a fairly intuitive solution to managing scopes and components once you see it like this.
Member
Author
|
Hi @mikkelhegn Let's go ahead to make things work first. I'm very open to any future discussions. Thanks! |
This was referenced Oct 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applicationScopessection is missing undercomponent. This PR fix it.closes https://github.com/microsoft/hydra-spec/issues/144 https://github.com/microsoft/hydra-spec/issues/130