Skip to content
This repository was archived by the owner on Sep 4, 2020. It is now read-only.

WIP add application scopes framework and healthscope#160

Closed
wonderflow wants to merge 7 commits intooam-dev:masterfrom
wonderflow:health-scop
Closed

WIP add application scopes framework and healthscope#160
wonderflow wants to merge 7 commits intooam-dev:masterfrom
wonderflow:health-scop

Conversation

@wonderflow
Copy link
Copy Markdown
Member

@wonderflow wonderflow commented Sep 16, 2019 •
edited
Loading

This PR is mainly to add application scope framework and health scope

This PR lasts several weeks mostly because the spec is changing.

https://github.com/microsoft/hydra-spec/issues/130
https://github.com/microsoft/hydra-spec/issues/144
https://github.com/microsoft/hydra-spec/pull/133
https://github.com/microsoft/hydra-spec/pull/127
https://github.com/microsoft/hydra-spec/pull/177
https://github.com/microsoft/hydra-spec/pull/196

add application scopes framework

  • 1. add framework for network/health
  • 2. create health scope instance
  • 3. check component scope overlap
  • 4. add/remove Component to scope

add health scope

  • 1. create a sub project to implement healthscope
  • 2. periodically aggregate status of health scope
  • 3. create a service to make health scope available for others
  • 4. docs for how to use it.

@wonderflow wonderflow closed this Sep 20, 2019
@wonderflow wonderflow deleted the health-scop branch September 20, 2019 02:05
@wonderflow wonderflow restored the health-scop branch September 20, 2019 02:05
@wonderflow wonderflow reopened this Sep 23, 2019
@wonderflow wonderflow self-assigned this Sep 25, 2019
@wonderflow wonderflow changed the title (WIP) add application scopes framework and check overlap WIP: add application scopes framework and healthscope Oct 11, 2019
@wonderflow wonderflow force-pushed the health-scop branch 2 times, most recently from 7204283 to 001bc53 Compare October 11, 2019 10:05
@wonderflow wonderflow force-pushed the health-scop branch 2 times, most recently from 40b0a9b to 3010f9a Compare October 11, 2019 15:16
@wonderflow
Copy link
Copy Markdown
Member Author

wonderflow commented Oct 11, 2019

@technosophos I find this PR could be very large, will it hard to review?

@wonderflow wonderflow changed the title WIP: add application scopes framework and healthscope add application scopes framework and healthscope Oct 14, 2019
wonderflow
wonderflow commented Oct 14, 2019
View reviewed changes
Comment thread healthscope/src/main.rs Outdated
Copy link
Copy Markdown
Member Author

@wonderflow wonderflow Oct 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we can't get health status response, because the client we invoke didn't implement async. kube-rs/kube#63

It will occur Error(BlockingClientInFutureContext) when we invoke synchronize function in hyper here .

I've tried several ways to work around, they don't work. Could someone more familiar with rust web framework than me give some help?

Copy link
Copy Markdown
Member Author

@wonderflow wonderflow Oct 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed this

@wonderflow wonderflow added Status: Blocked This issue or PR is blocked Status: Review Needed This is in PR and needs a review labels Oct 14, 2019
@wonderflow wonderflow added Status: Available This is available to be picked up by someone and removed Status: Blocked This issue or PR is blocked labels Oct 14, 2019
@wonderflow wonderflow changed the title add application scopes framework and healthscope WIP add application scopes framework and healthscope Oct 15, 2019
@wonderflow
Copy link
Copy Markdown
Member Author

wonderflow commented Oct 15, 2019

I am holding this PR back until after 1.0.0-alpha.1.

@wonderflow wonderflow mentioned this pull request Oct 16, 2019
Merged
8 tasks
@wonderflow
Copy link
Copy Markdown
Member Author

wonderflow commented Oct 16, 2019

closing this, we move to #367

@wonderflow wonderflow closed this Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@technosophos technosophos Awaiting requested review from technosophos

@hongchaodeng hongchaodeng Awaiting requested review from hongchaodeng

Assignees

@wonderflow wonderflow

Labels

Status: Available This is available to be picked up by someone Status: Review Needed This is in PR and needs a review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wonderflow