Feature: add application scopes framework and imp health scope by wonderflow · Pull Request #367 · oam-dev/rudr

wonderflow · 2019-10-16T07:50:39Z

This PR is mainly to add application scope framework and health scope

This PR lasts several weeks mostly because the spec is changing.

https://github.com/microsoft/hydra-spec/issues/130
https://github.com/microsoft/hydra-spec/issues/144
https://github.com/microsoft/hydra-spec/pull/133
https://github.com/microsoft/hydra-spec/pull/127
https://github.com/microsoft/hydra-spec/pull/177
https://github.com/microsoft/hydra-spec/pull/196

add application scopes framework

1. add framework for network/health
2. create health scope instance
3. check component scope overlap
4. add/remove Component to scope

add health scope

1. create a sub project to implement healthscope
2. periodically aggregate status of health scope
3. create a service to make health scope available for others
4. docs for how to use it.

This is same with #160 as we have changed repo, I have to make a new PR.

fixes #9

wonderflow · 2019-10-18T02:06:12Z

It seems the version of openssl installed by base image is 1.1.0 which didn't match the requirement of the updated lib.

I'm trying to figure out whether I should use a new base image

wonderflow · 2019-10-20T10:06:00Z

@technosophos @hongchaodeng I think this PR is ready for review now.

I have reset all the commits and split them into four big commits. Each commit is a separated part of code so you can review them one by one.

wonderflow · 2019-10-20T10:09:02Z

+		| cut -d: -f1 \
+		| sort -u \
+		| xargs -r apt-mark manual \
+&& apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false


kube-rs 0.6.1 need openssl 1.1.1 while using apt-get in debian:stretch-slim didn't work, so I have to compile from source here.

Maybe add the comments in the Dockerfile?

hongchaodeng

LGTM after nit.

The code is a great start to use Scope

hongchaodeng · 2019-10-21T04:09:19Z

@@ -0,0 +1,117 @@
+use crate::schematic::configuration::ComponentConfiguration;
+/// Network scope is defined as https://github.com/oam-dev/spec/blob/master/4.application_scopes.md#network-scope
+/// Now we don't really implement network scope, this is just a framework as the spec describe.


hongchaodeng · 2019-10-21T04:19:08Z

+		| cut -d: -f1 \
+		| sort -u \
+		| xargs -r apt-mark manual \
+&& apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false


Maybe add the comments in the Dockerfile?

hongchaodeng · 2019-10-21T04:20:59Z

@@ -0,0 +1,197 @@
+# Health Scope Controller
+
+Health Scope Controller used for periodically check health scope crd and check the health of all the components related.


Suggested change

Health Scope Controller used for periodically check health scope crd and check the health of all the components related.

HealthScope controller is used to periodically check the health of all the components and update health scope custom resources.

hongchaodeng · 2019-10-21T04:24:56Z

+                        };
+                    }
+                }
+                Err(e) => log::error!("get health scope list err {}", e),


Suggested change

Err(e) => log::error!("get health scope list err {}", e),

Err(e) => error!("get health scope list err {}", e),

hongchaodeng · 2019-10-21T04:37:43Z

+
+## What will health scope controller do?
+
+1. periodically check all component health and update the CR status.


Suggested change

1. periodically check all component health and update the CR status.

1. periodically check health status of components and update the HealthScope resource status.

hongchaodeng · 2019-10-21T04:40:50Z

+                debug!("health scope aggregate loop running...");
+            }
+            //FIXME: we could change this to use an informer if we have a runtime controller queue
+            std::thread::sleep(std::time::Duration::from_secs(1));


1s as default might be too frequent. Maybe 5s?

hongchaodeng · 2019-10-21T04:41:41Z

+    health_scope_watch.join().unwrap()
+}
+
+use std::{


Put this in the head of file?

hongchaodeng · 2019-10-21T04:41:58Z

+}
+
+type BoxFut = Box<dyn Future<Item = Response<Body>, Error = hyper::Error> + Send>;
+fn serve_health(req: Request<Body>) -> BoxFut {


add some comments?

hongchaodeng · 2019-10-21T04:42:02Z

+    Box::new(future::ok(response))
+}
+
+fn request_health(instance_name: String) -> Result<String, Error> {


add some comments?

hongchaodeng · 2019-10-21T04:42:16Z

+    Ok(health.to_string())
+}
+
+fn aggregate_health(


aggregate_health -> aggregate_components_health

hongchaodeng · 2019-10-21T04:44:56Z

ref oam-dev/spec#156

wonderflow · 2019-10-21T06:55:25Z

@hongchaodeng thanks very much, all comments are fixed in the last commit

hongchaodeng

lgtm

fibonacci1729 · 2019-10-22T14:46:43Z

@wonderflow i'll review this today.

technosophos

LGTM.

technosophos · 2019-10-24T18:11:43Z

+    }
+}
+
+// FIXME kube-rs client doesn't support async call so we have to wrap it in HealthFuture here.


This looks like a solid solution while we wait for the Kube upstream.

technosophos · 2019-10-24T18:13:18Z

The rebase that needs to be done is really simple, so feel free to merge as soon as you have rebased. I am excited to see this new addition!

2. check scope overlap 3. implement health scope

2. align rudr and oam 3. rust version up to 1.38 4. compile openssl 1.1.1 in DockerImage

wonderflow · 2019-10-25T00:52:45Z

Thanks @technosophos , I've rebased.

I noticed changes from #375 has been overrided by #366. I rebased it back here.

wonderflow · 2019-10-25T01:44:10Z

CI has passed, merging

wonderflow mentioned this pull request Oct 16, 2019

WIP add application scopes framework and healthscope #160

Closed

8 tasks

wonderflow force-pushed the health-scop branch from 1fddbf0 to 4d243f3 Compare October 17, 2019 05:58

wonderflow force-pushed the health-scop branch 3 times, most recently from 6004118 to dfc655e Compare October 18, 2019 05:34

suhuruli requested a review from technosophos October 18, 2019 17:03

wonderflow force-pushed the health-scop branch 2 times, most recently from 41310b6 to 330bac1 Compare October 20, 2019 10:03

wonderflow requested a review from hongchaodeng October 20, 2019 10:06

wonderflow added Status: Available This is available to be picked up by someone Status: Review Needed This is in PR and needs a review labels Oct 20, 2019

wonderflow self-assigned this Oct 20, 2019

wonderflow commented Oct 20, 2019

View reviewed changes

hongchaodeng approved these changes Oct 21, 2019

View reviewed changes

wonderflow mentioned this pull request Oct 21, 2019

scope: add example health scope oam-dev/spec#156

Closed

hongchaodeng reviewed Oct 21, 2019

View reviewed changes

technosophos approved these changes Oct 24, 2019

View reviewed changes

technosophos added Status: Needs rebase PR is awaiting a rebase and removed Status: Review Needed This is in PR and needs a review labels Oct 24, 2019

wonderflow added 5 commits October 25, 2019 08:39

1. add application scope framework

d27d0e7

2. check scope overlap 3. implement health scope

init healthscope controller

1adf93f

add healthscope chart for healthscope controller

71a9a0a

1. update kube-rs to 0.16.1 enable owner_referrence

29ee5d6

2. align rudr and oam 3. rust version up to 1.38 4. compile openssl 1.1.1 in DockerImage

small fixes according to comments

b01c587

wonderflow force-pushed the health-scop branch from 72308eb to b01c587 Compare October 25, 2019 00:49

wonderflow merged commit 2298a35 into oam-dev:master Oct 25, 2019

wonderflow deleted the health-scop branch October 25, 2019 01:44

		@@ -0,0 +1,197 @@
		# Health Scope Controller

		Health Scope Controller used for periodically check health scope crd and check the health of all the components related.

	Health Scope Controller used for periodically check health scope crd and check the health of all the components related.
	HealthScope controller is used to periodically check the health of all the components and update health scope custom resources.

	Err(e) => log::error!("get health scope list err {}", e),
	Err(e) => error!("get health scope list err {}", e),


		## What will health scope controller do?

		1. periodically check all component health and update the CR status.

	1. periodically check all component health and update the CR status.
	1. periodically check health status of components and update the HealthScope resource status.

Conversation

wonderflow commented Oct 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

add application scopes framework

add health scope

Uh oh!

wonderflow commented Oct 18, 2019

Uh oh!

wonderflow commented Oct 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hongchaodeng left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hongchaodeng commented Oct 21, 2019

Uh oh!

wonderflow commented Oct 21, 2019

Uh oh!

hongchaodeng left a comment

Choose a reason for hiding this comment

Uh oh!

fibonacci1729 commented Oct 22, 2019

Uh oh!

technosophos left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

technosophos commented Oct 24, 2019

Uh oh!

wonderflow commented Oct 25, 2019

Uh oh!

wonderflow commented Oct 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wonderflow commented Oct 16, 2019 •

edited

Loading

wonderflow commented Oct 20, 2019 •

edited

Loading