Skip to content

fix the invalid stack exception during evaluation #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andxu merged 1 commit into from
Mar 26, 2018
Merged

fix the invalid stack exception during evaluation #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions check_style.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,6 @@
<property name="tokens" value="LITERAL_TRY, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>
</module>
<module name="NeedBraces"/>
<module name="LeftCurly">
<property name="maxLineLength" value="120"/>
</module>
<module name="RightCurly">
<property name="id" value="RightCurlySame"/>
<property name="tokens"
Expand Down
2 changes: 1 addition & 1 deletion ...in/src/main/java/com/microsoft/java/debug/plugin/internal/eval/JdtEvaluationProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public CompletableFuture<Value> evaluateForBreakpoint(IBreakpoint breakpoint, Th
try {
ensureDebugTarget(thread.virtualMachine(), thread, 0);
JDIThread jdiThread = getMockJDIThread(thread);
JDIStackFrame stackframe = (JDIStackFrame) jdiThread.getTopStackFrame();
JDIStackFrame stackframe = new JDIStackFrame(jdiThread, thread.frame(0), 0);
Copy link
Copy Markdown
Contributor

@testforstephen testforstephen Mar 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why update it? Is JDIStackFrame changed by jdt library?

Copy link
Copy Markdown
Contributor Author

@andxu andxu Mar 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getTopStackFrame uses the inner cache in Jdithread, it will have the possibility to become invalid


ASTEvaluationEngine engine = new ASTEvaluationEngine(project, debugTarget);
ICompiledExpression ie = (ICompiledExpression) breakpointExpressionMap
Expand Down