Helper function prototype

[amurgZainar]

Hello,

In the "Add new helper function" document, when you talk about the helper function registration with the verifier, the new_helper_implementation() declaration doesn't match the jbpf_helper_func_t type.

static int
new_helper_implementation(void* jbpf_ctx, int a, int b, int c)

There is a difference between the number of arguments in the new_helper_implementation declaration and the jbpf_helper_func_t type. Is this meant to highlight that the new helper function always has to be casted to the jbpf_helper_func_t type? Also, in the verifier, we should be specifying the types only for the parameters given in the helper function declaration, no matter the definition of jbpf_helper_func_t type, right?

Also, about the types of the arguments for a new helper function. If, for example, one of the arguments is of a custom type (e.g., my_struct), do we need to specify that argument in the helper function declaration as void *arg1, instead of using the pointer to that custom type, e.g., my_struct *arg1?

Thanks.

[doctorlai-msrc]

The helper function will be casted to jbpf_helper_func_t when e.g. registering. Currently, any help functions can be supported up to 5 arguments.

As regarding the parameter types, you can use either void* arg1 or my_struct *arg1.

[amurgZainar]

OK, thanks.