Add NULL check after struct_field_read_integer calls#12
Open
hobostay wants to merge 1 commit intomicrosoft:publicfrom
Open
Add NULL check after struct_field_read_integer calls#12hobostay wants to merge 1 commit intomicrosoft:publicfrom
hobostay wants to merge 1 commit intomicrosoft:publicfrom
Conversation
The macros struct_field_get_unsigned_int and struct_field_get_signed_int call struct_field_read_integer which can return NULL when the field is out of bounds of the provided memory. Add a NULL check to prevent undefined behavior from dereferencing a NULL pointer. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
struct_field_get_unsigned_intandstruct_field_get_signed_intmacros insrc/0xc/std/struct.hDetails
The macros
struct_field_get_unsigned_intandstruct_field_get_signed_intboth callstruct_field_read_integer(), which can returnNULLwhenstruct_field_get_untypedreturns NULL (i.e., when the field is out of bounds of the provided memory buffer).Both macros currently dereference the result without checking for NULL:
This adds a NULL check with a descriptive panic message to prevent undefined behavior from a NULL pointer dereference.
Test plan
make test)🤖 Generated with Claude Code