Skip to content

Fix WinHttpProvider caching a null WinHTTP session permanently #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andy McCalib (amccalib) merged 1 commit into from
Aug 4, 2026
+7 −5
Merged

Fix WinHttpProvider caching a null WinHTTP session permanently #1010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions Source/HTTP/WinHttp/winhttp_provider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,8 +399,7 @@ Result<HINTERNET> WinHttpProvider::GetHSession(uint32_t securityProtocolFlags, c
openFlags
);

DWORD error = GetLastError();
if (error == ERROR_INVALID_PARAMETER && isHttps)
if (hSession == nullptr && GetLastError() == ERROR_INVALID_PARAMETER && isHttps)
{
// WINHTTP_FLAG_SECURE_DEFAULTS exists only on newer Windows versions;
// on earlier OS releases we will receive ERROR_INVALID_PARAMETER and should continue without it.
Expand All @@ -414,7 +413,8 @@ Result<HINTERNET> WinHttpProvider::GetHSession(uint32_t securityProtocolFlags, c

if (hSession == nullptr)
{
HRESULT hr = HRESULT_FROM_WIN32(GetLastError());
DWORD openErr = GetLastError();
HRESULT hr = openErr != 0 ? HRESULT_FROM_WIN32(openErr) : E_FAIL;
HC_TRACE_ERROR_HR(HTTPCLIENT, hr, "WinHttpProvider WinHttpOpen");
return hr;
}
Expand Down Expand Up @@ -452,8 +452,10 @@ Result<HINTERNET> WinHttpProvider::GetHSession(uint32_t securityProtocolFlags, c
WINHTTP_FLAG_ASYNC);
if (hSession == nullptr)
{
HRESULT openHr = HRESULT_FROM_WIN32(GetLastError());
HC_TRACE_WARNING_HR(HTTPCLIENT, openHr, "WinHttpProvider fallback WinHttpOpen with WINHTTP_FLAG_ASYNC failed; continuing without explicitly setting secure protocols");
DWORD openErr = GetLastError();
HRESULT openHr = openErr != 0 ? HRESULT_FROM_WIN32(openErr) : E_FAIL;
HC_TRACE_ERROR_HR(HTTPCLIENT, openHr, "WinHttpProvider fallback WinHttpOpen with WINHTTP_FLAG_ASYNC failed");
return openHr;
}
else
{
Expand Down
Loading