Support data disk for shared image gallery transformer - #4521
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for including data disk VHDs when creating a Shared Image Gallery (SIG) image version via the azure_sig transformer, and adjusts the ARM/Bicep template to emit null for dataDisks when no data disks are specified.
Changes:
- Extend
azure_sigtransformer configuration to accept either a string VHD URI (back-compat) or an object that can also carry data disk VHD URIs. - Validate existence of both OS and data disk blobs and pass data disk sources into SIG image version creation.
- Update ARM/Bicep templates so
dataDisksbecomesnull(omitted) whendata_disksis empty.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lisa/sut_orchestrator/azure/transformers.py | Accepts structured VHD inputs (OS + data disks), resolves/copies VHD URIs, and validates blob existence before SIG creation. |
| lisa/sut_orchestrator/azure/common.py | Adds optional data_vhd_paths and populates storageProfile.dataDiskImages when creating a SIG image version. |
| lisa/sut_orchestrator/azure/autogen_arm_template.json | Emits null for dataDisks when no data disks are specified (generated output). |
| lisa/sut_orchestrator/azure/arm_template.bicep | Implements the conditional dataDisks: null behavior in source Bicep. |
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
dc43fed to
bc69490
Compare
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
87fbd5e to
e6b1bfb
Compare
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
e6b1bfb to
8e90d3e
Compare
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
Description
Related Issue
Type of Change
Checklist
Test Validation
Test has been passed with the following runbook:
Tests have been passed with the following image with data disk:
ibm-usa-ny-armonk-hq-6275750-ibmcloud-aiops 2023-03-27-twas-single-server-base-image 2023-03-27-twas-single-server-base-image 9.0.20250429